Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mlbridge: use consistent conf for webrevs #724

Closed
wants to merge 1 commit into from

Conversation

edvbld
Copy link
Member

@edvbld edvbld commented Aug 18, 2020

Hi all,

please review this small patch that makes the configuration for the mlbridge bot use consistent spelling for the "webrevs" fields.

Testing:

  • make test on Linux x64 passes

Thanks,
Erik


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Reviewers

Download

$ git fetch https://git.openjdk.java.net/skara pull/724/head:pull/724
$ git checkout pull/724

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Aug 18, 2020

👋 Welcome back ehelin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Aug 18, 2020

Webrevs

@edvbld
Copy link
Member Author

@edvbld edvbld commented Aug 18, 2020

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Aug 18, 2020

@edvbld Your merge request cannot be fulfilled at this time, as your changes failed the final jcheck:

  • Too few reviewers with at least role reviewer found (have 0, need at least 1)

Copy link
Member

@rwestberg rwestberg left a comment

Looks good!

@openjdk
Copy link

@openjdk openjdk bot commented Aug 18, 2020

@edvbld This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

mlbridge: use consistent conf for webrevs

Reviewed-by: rwestberg
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there has been 1 commit pushed to the master branch:

  • edb4d04: build: update to JDK 14.0.2

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate edb4d049b31011a1b6145789b1d4e5f20c9bf600.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Aug 18, 2020
@edvbld
Copy link
Member Author

@edvbld edvbld commented Aug 18, 2020

/integrate

@openjdk openjdk bot closed this Aug 18, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Aug 18, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Aug 18, 2020

@edvbld The following commits have been pushed to master since your change was applied:

  • edb4d04: build: update to JDK 14.0.2

Your commit was automatically rebased without conflicts.

Pushed as commit 1dbd418.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants