Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git: support unicode filenames #728

Closed
wants to merge 2 commits into from
Closed

git: support unicode filenames #728

wants to merge 2 commits into from

Conversation

edvbld
Copy link
Member

@edvbld edvbld commented Aug 21, 2020

Hi all,

please review this patch that adds support for unicode filenames to GitRepository. I also added a unit test exercising the new functionality.

Testing:

  • make test passes on Linux x64
  • Added a new unit test

Thanks,
Erik


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Reviewers

Download

$ git fetch https://git.openjdk.java.net/skara pull/728/head:pull/728
$ git checkout pull/728

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Aug 21, 2020

👋 Welcome back ehelin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@openjdk openjdk bot added the rfr label Aug 21, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Aug 21, 2020

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented Aug 21, 2020

@edvbld this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout unicode
git fetch https://git.openjdk.java.net/skara master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push

Copy link
Member

@rwestberg rwestberg left a comment

Looks good!

@openjdk
Copy link

@openjdk openjdk bot commented Aug 21, 2020

@edvbld This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

git: support unicode filenames

Reviewed-by: rwestberg
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there have been 5 commits pushed to the master branch:

  • 4175a74: git: commitMetadata should return commits in topo order
  • becfd45: git: allow diffs against initial revision
  • 3916cb7: hg: implement hashes for blobs for ls-tree
  • 1dbd418: mlbridge: use consistent conf for webrevs
  • edb4d04: build: update to JDK 14.0.2

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate 4175a74b2da37ff18bc07b568b683ea55090133e.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Aug 21, 2020
@edvbld
Copy link
Member Author

@edvbld edvbld commented Aug 22, 2020

/integrate

@openjdk openjdk bot closed this Aug 22, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Aug 22, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Aug 22, 2020

@edvbld The following commits have been pushed to master since your change was applied:

  • 4175a74: git: commitMetadata should return commits in topo order
  • becfd45: git: allow diffs against initial revision
  • 3916cb7: hg: implement hashes for blobs for ls-tree
  • 1dbd418: mlbridge: use consistent conf for webrevs
  • edb4d04: build: update to JDK 14.0.2

Your commit was automatically rebased without conflicts.

Pushed as commit 2413ed8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants