Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mailing list filter rule generator / verifier #733

Closed
wants to merge 6 commits into from

Conversation

rwestberg
Copy link
Member

@rwestberg rwestberg commented Aug 24, 2020

Hi all,

Please review this change that introduces the "mlrules" command, which can be used to generate and verify mailing list filter rules for the jdk/jdk family of development mailing lists. These filter rules can be used by the Skara bots when figuring out on which list(s) a jdk pull request should be reviewed.

The idea is that this command can be used by knowledgeable OpenJDK developers to help improve the quality of the filter rules that will eventually end up being used when the jdk repository starts using pull requests. Examples of usage, together with an initial version of these filter rules, will be posted separately.

Best regards,
Robin


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Reviewers

  • Erik Helin (ehelin - Reviewer) ⚠️ Review applies to ef12979

Download

$ git fetch https://git.openjdk.java.net/skara pull/733/head:pull/733
$ git checkout pull/733

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Aug 24, 2020

👋 Welcome back rwestberg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Aug 24, 2020

edvbld
edvbld approved these changes Aug 24, 2020
Copy link
Member

@edvbld edvbld left a comment

Looks good in general! I would suggest renaming GitDebug.java to SkaraDebug.java (and GitDebugHelp to SkaraDebugHelp). I also added a few minor inline comments.

cli/src/main/java/org/openjdk/skara/cli/GitDebug.java Outdated Show resolved Hide resolved
cli/src/main/java/org/openjdk/skara/cli/GitDebug.java Outdated Show resolved Hide resolved
cli/src/main/java/org/openjdk/skara/cli/GitDebug.java Outdated Show resolved Hide resolved
cli/src/main/java/org/openjdk/skara/cli/GitDebug.java Outdated Show resolved Hide resolved
@openjdk
Copy link

@openjdk openjdk bot commented Aug 24, 2020

@rwestberg This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

Mailing list filter rule generator / verifier

Reviewed-by: ehelin
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there has been 1 commit pushed to the master branch:

  • 6c52d67: vcs: don't append newlines to tag messages

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate 6c52d67a0f0b988c58cb157df7b1bb2c22cee414.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Aug 24, 2020
Robin Westberg and others added 3 commits Aug 24, 2020
Co-authored-by: Erik Duveblad <erik.helin@oracle.com>
Co-authored-by: Erik Duveblad <erik.helin@oracle.com>
@rwestberg
Copy link
Member Author

@rwestberg rwestberg commented Aug 24, 2020

/integrate

@openjdk openjdk bot closed this Aug 24, 2020
@openjdk openjdk bot added integrated and removed ready labels Aug 24, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Aug 24, 2020

@rwestberg The following commits have been pushed to master since your change was applied:

  • 6c52d67: vcs: don't append newlines to tag messages

Your commit was automatically rebased without conflicts.

Pushed as commit 71e10af.

@openjdk openjdk bot removed the rfr label Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants