Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store target hash before potentially fetching the ref #742

Closed
wants to merge 1 commit into from

Conversation

rwestberg
Copy link
Member

@rwestberg rwestberg commented Aug 26, 2020

Hi all,

Please review this change that determines the hash of the target ref for a PR before returning the ref. This ensures that subsequently fetching the ref contains the hash (barring concurrent force pushes to the target ref, which should never happen).

Best regards,
Robin


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Reviewers

  • Erik Helin (ehelin - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/skara pull/742/head:pull/742
$ git checkout pull/742

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Aug 26, 2020

👋 Welcome back rwestberg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@openjdk openjdk bot added the rfr label Aug 26, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Aug 26, 2020

Webrevs

edvbld
edvbld approved these changes Aug 26, 2020
Copy link
Member

@edvbld edvbld left a comment

Looks good!

@openjdk
Copy link

@openjdk openjdk bot commented Aug 26, 2020

@rwestberg This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

Store target hash before potentially fetching the ref

Reviewed-by: ehelin
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there have been 4 commits pushed to the master branch:

  • 5459a0b: webrev: follow files for commits.json
  • 05d9d69: vcs: add method ReadOnlyRepository.follow
  • d6a5ab4: hg: use --template instead of ext.py for metadata
  • 87141a3: actions: Use explicit versions of OS environments

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate 5459a0b41d30453363478a061bac94da124f99e4.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Aug 26, 2020
@rwestberg
Copy link
Member Author

@rwestberg rwestberg commented Aug 26, 2020

/integrate

@openjdk openjdk bot closed this Aug 26, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Aug 26, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Aug 26, 2020

@rwestberg The following commits have been pushed to master since your change was applied:

  • 5459a0b: webrev: follow files for commits.json
  • 05d9d69: vcs: add method ReadOnlyRepository.follow
  • d6a5ab4: hg: use --template instead of ext.py for metadata
  • 87141a3: actions: Use explicit versions of OS environments

Your commit was automatically rebased without conflicts.

Pushed as commit 089215d.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants