Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

checkout bot: use full path for marks files #745

Closed
wants to merge 1 commit into from

Conversation

edvbld
Copy link
Member

@edvbld edvbld commented Aug 26, 2020

Hi all,

please review this small fix that makes the checkout bot use the full path of the from repo as the name for the marks file. I also had to update HostedRepositoryStorage to cope with files in directories.

Testing:

  • make test passes on Linux x64

Thanks,
Erik


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Reviewers

Download

$ git fetch https://git.openjdk.java.net/skara pull/745/head:pull/745
$ git checkout pull/745

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Aug 26, 2020

👋 Welcome back ehelin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Aug 26, 2020

Webrevs

Copy link
Member

@rwestberg rwestberg left a comment

Looks good!

@openjdk
Copy link

@openjdk openjdk bot commented Aug 27, 2020

@edvbld This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

checkout bot: use full path for marks files

Reviewed-by: rwestberg
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

There are currently no new commits on the master branch since the last update of the source branch of this PR. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you would like to avoid potential automatic rebasing, specify the current head hash when integrating, like this: /integrate 0d9698bdbb22adbc65f0af9f70f1790a0280914a.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Aug 27, 2020
@edvbld
Copy link
Member Author

@edvbld edvbld commented Aug 27, 2020

/integrate

@openjdk openjdk bot closed this Aug 27, 2020
@openjdk openjdk bot added integrated and removed ready labels Aug 27, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Aug 27, 2020

@edvbld
Pushed as commit 8a2d11c.

@openjdk openjdk bot removed the rfr label Aug 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants