New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates to config/mailinglist/rules/jdk.json related to compiler-dev and kulla-dev. #748
Conversation
|
"src/hotspot/share/interpreter/templateTable.cpp", | ||
"src/hotspot/share/interpreter/templateTable.hpp", | ||
"src/hotspot/share/runtime/reflection.hpp", | ||
"src/java.base/share/classes/java/lang/", | ||
"src/java.base/share/classes/jdk/internal/PreviewFeature.java", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this shows the question on maintenance from the jdk-dev list - the (internal) PreviewFeature may be moved to a different (internal) place sometime in the foreseeable future. Who will be updating this list?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When in doubt, I think it's better to err on the side of caution, so perhaps it should not be included in the list at all. But will expand on this in the jdk-dev thread.
@lahodaj This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type
Since the source branch of this PR was last updated there has been 1 commit pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge As you do not have Committer status in this project, an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@rwestberg) but any other Committer may sponsor as well.
|
/integrate |
/sponsor |
@rwestberg @lahodaj The following commits have been pushed to master since your change was applied:
Your commit was automatically rebased without conflicts. Pushed as commit 92a9799. |
…and kulla-dev.
I tried to keep the sensible stuff, sending to multiple lists where in a real doubt. Some other javac/javadoc maintainers may disagree with some of the choices, though.
Progress
Reviewers
Download
$ git fetch https://git.openjdk.java.net/skara pull/748/head:pull/748
$ git checkout pull/748