Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to config/mailinglist/rules/jdk.json related to compiler-dev and kulla-dev. #748

Closed
wants to merge 1 commit into from

Conversation

lahodaj
Copy link

@lahodaj lahodaj commented Aug 27, 2020

…and kulla-dev.

I tried to keep the sensible stuff, sending to multiple lists where in a real doubt. Some other javac/javadoc maintainers may disagree with some of the choices, though.


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Reviewers

Download

$ git fetch https://git.openjdk.java.net/skara pull/748/head:pull/748
$ git checkout pull/748

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Aug 27, 2020

👋 Welcome back jlahoda! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@openjdk openjdk bot added the rfr label Aug 27, 2020
"src/hotspot/share/interpreter/templateTable.cpp",
"src/hotspot/share/interpreter/templateTable.hpp",
"src/hotspot/share/runtime/reflection.hpp",
"src/java.base/share/classes/java/lang/",
"src/java.base/share/classes/jdk/internal/PreviewFeature.java",
Copy link
Author

@lahodaj lahodaj Aug 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this shows the question on maintenance from the jdk-dev list - the (internal) PreviewFeature may be moved to a different (internal) place sometime in the foreseeable future. Who will be updating this list?

Copy link
Member

@rwestberg rwestberg Aug 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When in doubt, I think it's better to err on the side of caution, so perhaps it should not be included in the list at all. But will expand on this in the jdk-dev thread.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Aug 27, 2020

Webrevs

Copy link
Member

@rwestberg rwestberg left a comment

Thanks for the update!

@openjdk
Copy link

@openjdk openjdk bot commented Aug 28, 2020

@lahodaj This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

Updates to config/mailinglist/rules/jdk.json related to compiler-dev and kulla-dev.

Reviewed-by: rwestberg
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there has been 1 commit pushed to the master branch:

  • aca3439: 542: Adjust label (cc) command logic

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate aca3439640f72b6c3a6da5b8789ce10cbe7bd6d1.

As you do not have Committer status in this project, an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@rwestberg) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Aug 28, 2020
@lahodaj lahodaj changed the title Updates to config/mailinglist/rules/jdk.json related to compiler-dev … Updates to config/mailinglist/rules/jdk.json related to compiler-dev and kulla-dev. Aug 28, 2020
@lahodaj
Copy link
Author

@lahodaj lahodaj commented Aug 28, 2020

/integrate

@openjdk openjdk bot added the sponsor label Aug 28, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Aug 28, 2020

@lahodaj
Your change (at version 3d59181) is now ready to be sponsored by a Committer.

@rwestberg
Copy link
Member

@rwestberg rwestberg commented Aug 28, 2020

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Aug 28, 2020

@rwestberg @lahodaj The following commits have been pushed to master since your change was applied:

  • aca3439: 542: Adjust label (cc) command logic

Your commit was automatically rebased without conflicts.

Pushed as commit 92a9799.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants