Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small updates to jdk.json mapping #751

Closed
wants to merge 3 commits into from
Closed

Conversation

@jddarcy
Copy link
Member

@jddarcy jddarcy commented Aug 28, 2020

Simplify AIX libjli mapping and remove various HotSpot regression tests from core-libs-dev.


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Reviewers

Download

$ git fetch https://git.openjdk.java.net/skara pull/751/head:pull/751
$ git checkout pull/751

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Aug 28, 2020

👋 Welcome back darcy! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@openjdk openjdk bot added the rfr label Aug 28, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Aug 28, 2020

Webrevs

Copy link
Member

@rwestberg rwestberg left a comment

Thanks for the update!

@openjdk
Copy link

@openjdk openjdk bot commented Aug 29, 2020

@jddarcy This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

Small updates to jdk.json mapping

Reviewed-by: rwestberg
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there have been 11 commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate d533135bdf274bb42693fd9ff354ad2f5de3991b.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Aug 29, 2020
@jddarcy
Copy link
Member Author

@jddarcy jddarcy commented Aug 29, 2020

I condensed down the mappings covering
src/java.base/share/classes/jdk/internal/*
and verified all the previously listed directories where still mapped to core-libs using
git skara debug mlrules -v $PATH_TO_MODIFIED_FILE

@jddarcy
Copy link
Member Author

@jddarcy jddarcy commented Sep 1, 2020

/intergrate

@openjdk
Copy link

@openjdk openjdk bot commented Sep 1, 2020

@jddarcy Unknown command intergrate - for a list of valid commands use /help.

@jddarcy
Copy link
Member Author

@jddarcy jddarcy commented Sep 1, 2020

/integrate

@openjdk openjdk bot closed this Sep 1, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 1, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 1, 2020

@jddarcy The following commits have been pushed to master since your change was applied:

  • d533135: Update jdk.json
  • 59448e7: storage: support nested paths in file storage
  • 931a0b1: checkout-bot: remote leading slash from path
  • 159f939: 448: Rerun check after updating title
  • cca94e0: 265: Mail bot shows wrong source line for inline review comments
  • b007595: 439: Improve command filtering when bridging mails
  • e36b503: prbot: Allow overriding jcheck configuration
  • b028725: webrev: not all commits changes files
  • 0e4356a: tester: allow configurable allowlist
  • 8a7eb77: vcs: make follow work with merge commits
  • e954044: git-pr-create: be explicit about CC:d mailing lists

Your commit was automatically rebased without conflicts.

Pushed as commit 3746ea5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants