webrev: not all commits changes files #754
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Hi all,
please review this small patch that updates webrev's JSON generator to handle commits that don't change any files. This can happen for example with trivial merges (since we use the
-c
flag togit log
).Thanks,
Erik
Progress
Reviewers
Download
$ git fetch https://git.openjdk.java.net/skara pull/754/head:pull/754
$ git checkout pull/754