Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webrev: not all commits changes files #754

wants to merge 1 commit into from


Copy link

@edvbld edvbld commented Aug 30, 2020

Hi all,

please review this small patch that updates webrev's JSON generator to handle commits that don't change any files. This can happen for example with trivial merges (since we use the -c flag to git log).



  • Change must not contain extraneous whitespace
  • Change must be properly reviewed



$ git fetch pull/754/head:pull/754
$ git checkout pull/754

Copy link

@bridgekeeper bridgekeeper bot commented Aug 30, 2020

👋 Welcome back ehelin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@openjdk openjdk bot added the rfr label Aug 30, 2020
Copy link

@mlbridge mlbridge bot commented Aug 30, 2020


Copy link

@rwestberg rwestberg left a comment

Looks good!

Copy link

@openjdk openjdk bot commented Aug 30, 2020

@edvbld This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

webrev: not all commits changes files

Reviewed-by: rwestberg
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

There are currently no new commits on the master branch since the last update of the source branch of this PR. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you would like to avoid potential automatic rebasing, specify the current head hash when integrating, like this: /integrate 0e4356a081c379c283759b47661d68c276f2b047.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Aug 30, 2020
Copy link
Member Author

@edvbld edvbld commented Aug 31, 2020


@openjdk openjdk bot closed this Aug 31, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Aug 31, 2020
Copy link

@openjdk openjdk bot commented Aug 31, 2020

Pushed as commit b028725.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants