Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

439: Improve command filtering when bridging mails #756

Closed
wants to merge 1 commit into from

Conversation

rwestberg
Copy link
Member

@rwestberg rwestberg commented Aug 31, 2020

Hi all,

Please review this change that improves the command comment filtering done by the mailinglist bridge bot, to match more closely what the pull request bot would consider as commands.

Best regards,
Robin


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Issue

  • SKARA-439: Improve command filtering when bridging mails

Reviewers

  • Erik Helin (ehelin - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/skara pull/756/head:pull/756
$ git checkout pull/756

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Aug 31, 2020

👋 Welcome back rwestberg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@openjdk openjdk bot changed the title 439 439: Improve command filtering when bridging mails Aug 31, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Aug 31, 2020

Webrevs

edvbld
edvbld approved these changes Aug 31, 2020
Copy link
Member

@edvbld edvbld left a comment

Looks good!

@openjdk
Copy link

@openjdk openjdk bot commented Aug 31, 2020

@rwestberg This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

439: Improve command filtering when bridging mails

Reviewed-by: ehelin
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there have been 2 commits pushed to the master branch:

  • e36b503: prbot: Allow overriding jcheck configuration
  • b028725: webrev: not all commits changes files

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate e36b503e7a3e078021d20cd0ad1f0370cbce1ca6.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Aug 31, 2020
@rwestberg
Copy link
Member Author

@rwestberg rwestberg commented Aug 31, 2020

/integrate

@openjdk openjdk bot closed this Aug 31, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Aug 31, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Aug 31, 2020

@rwestberg The following commits have been pushed to master since your change was applied:

  • e36b503: prbot: Allow overriding jcheck configuration
  • b028725: webrev: not all commits changes files

Your commit was automatically rebased without conflicts.

Pushed as commit b007595.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants