Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

549: Links to users under Reviewers lead to a 404 page #763

Closed
wants to merge 1 commit into from

Conversation

rwestberg
Copy link
Member

@rwestberg rwestberg commented Sep 2, 2020

Hi all,

Please review this change that improves the formatting of user names / link listed under Reviewers in the PR body. With proper configuration, it will look something like this:

Best regards,
Robin


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Issue

  • SKARA-549: Links to users under Reviewers lead to a 404 page

Reviewers

  • Erik Helin (ehelin - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/skara pull/763/head:pull/763
$ git checkout pull/763

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 2, 2020

👋 Welcome back rwestberg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@openjdk openjdk bot changed the title 549 549: Links to users under Reviewers lead to a 404 page Sep 2, 2020
@mlbridge
Copy link

mlbridge bot commented Sep 2, 2020

Webrevs

edvbld
edvbld approved these changes Sep 2, 2020
Copy link
Member

@edvbld edvbld left a comment

Looks good!

@openjdk
Copy link

openjdk bot commented Sep 2, 2020

@rwestberg This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

549: Links to users under Reviewers lead to a 404 page

Reviewed-by: ehelin
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

There are currently no new commits on the master branch since the last update of the source branch of this PR. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you would like to avoid potential automatic rebasing, specify the current head hash when integrating, like this: /integrate 614cb720332d8e630685cb2380b05914134d4aab.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Sep 2, 2020
@rwestberg
Copy link
Member Author

rwestberg commented Sep 3, 2020

/integrate

@openjdk openjdk bot closed this Sep 3, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 3, 2020
@openjdk
Copy link

openjdk bot commented Sep 3, 2020

@rwestberg
Pushed as commit 30f1d04.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants