Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: remote git-expand command #769

Closed
wants to merge 1 commit into from
Closed

Conversation

@edvbld
Copy link
Member

@edvbld edvbld commented Sep 4, 2020

Hi all,

please remove this patch that removes the very rarely used git-expand CLI command. git-expand does not carry its weight ever since we introduced automatic expanding of pull requests titles (done server-side via the bots).

Testing:

  • make test on Linux x64
  • make on Linux x64
  • Verified that git-expand is no longer present

Thanks,
Erik


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Reviewers

Download

$ git fetch https://git.openjdk.java.net/skara pull/769/head:pull/769
$ git checkout pull/769

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 4, 2020

👋 Welcome back ehelin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@openjdk openjdk bot added rfr cli labels Sep 4, 2020
Copy link
Member

@rwestberg rwestberg left a comment

Looks good!

@openjdk
Copy link

@openjdk openjdk bot commented Sep 4, 2020

@edvbld This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

cli: remote git-expand command

Reviewed-by: rwestberg
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

There are currently no new commits on the master branch since the last update of the source branch of this PR. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you would like to avoid potential automatic rebasing, specify the current head hash when integrating, like this: /integrate 07930a41b263168d8ea250def33d5f11ee4de88b.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Sep 4, 2020
@edvbld
Copy link
Member Author

@edvbld edvbld commented Sep 4, 2020

/integrate

@openjdk openjdk bot closed this Sep 4, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 4, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 4, 2020

@edvbld
Pushed as commit ba720a3.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 4, 2020

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.