Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git-pr: remove --no-commit from git apply #788

Closed
wants to merge 1 commit into from

Conversation

@edvbld
Copy link
Member

@edvbld edvbld commented Sep 5, 2020

Hi all,

please review this patch that removes --no-commit from git apply in pr/Utils.java (a left-over from some Mercurial experimentation).

Thanks,
Erik


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Reviewers

Download

$ git fetch https://git.openjdk.java.net/skara pull/788/head:pull/788
$ git checkout pull/788

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 5, 2020

👋 Welcome back ehelin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Sep 5, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 5, 2020

@edvbld The following labels will be automatically applied to this pull request: cli. When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label (add|remove) "label" command.

@openjdk openjdk bot added the cli label Sep 5, 2020
Copy link
Member

@rwestberg rwestberg left a comment

Looks good!

@openjdk
Copy link

@openjdk openjdk bot commented Sep 5, 2020

@edvbld This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

git-pr: remove --no-commit from git apply

Reviewed-by: rwestberg
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there has been 1 commit pushed to the master branch:

  • ecbeb09: Include 'treconfigure' in help for git trees

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate ecbeb097d3201bbdeb60157524ea979a1a3177a0.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Sep 5, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 5, 2020

Webrevs

@edvbld
Copy link
Member Author

@edvbld edvbld commented Sep 5, 2020

/integrate

@openjdk openjdk bot closed this Sep 5, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 5, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 5, 2020

@edvbld The following commits have been pushed to master since your change was applied:

  • ecbeb09: Include 'treconfigure' in help for git trees

Your commit was automatically rebased without conflicts.

Pushed as commit fbac52c.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.