Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make webrev reject positional arguments #79

Closed
wants to merge 4 commits into from
Closed

Conversation

lkorinth
Copy link

@lkorinth lkorinth commented Aug 23, 2019

Update the man page to reflect accumulated changes to webrev arguments.

Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Approvers

Update the man page to reflect accumulated changes to webrev arguments.
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Aug 23, 2019

👋 Welcome back lkorinth! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request (refresh this page to view it).

@mlbridge
Copy link

@mlbridge mlbridge bot commented Aug 23, 2019

Webrevs

Copy link
Member

@edvbld edvbld left a comment

Thanks Leo, looks good in general, but I would like to be a bit more neutral with regards to Mercurial in the man page (see my suggestions).

cli/resources/man/man1/git-webrev.1 Outdated Show resolved Hide resolved
cli/resources/man/man1/git-webrev.1 Outdated Show resolved Hide resolved
lkorinth and others added 2 commits Aug 26, 2019
Co-Authored-By: Erik Duveblad <erik.helin@oracle.com>
Co-Authored-By: Erik Duveblad <erik.helin@oracle.com>
edvbld
edvbld approved these changes Aug 26, 2019
Copy link
Member

@edvbld edvbld left a comment

Looks good, thanks Leo!

@openjdk openjdk bot removed the rfr label Aug 26, 2019
@openjdk
Copy link

@openjdk openjdk bot commented Aug 26, 2019

@lkorinth This change can now be integrated. The commit message will be:

Make webrev reject positional arguments

Reviewed-by: ehelin
  • If you would like to add a summary, use the /summary command.
  • To list additional contributors, use the /contributor command.

Since the source branch of this PR was last updated there have been 4 commits pushed to the master branch:

  • c730de2: Fix webrev generation when target hunk is empty
  • 3436186: Add ReadOnlyRepository::status
  • 5799042: Add ReadOnlyRepository::dump
  • 20c3f55: Adding project explanation

Since there are no conflicts, your changes will automatically be rebased on top of the above commits when integrating. If you prefer to do this manually, please merge master into your branch first.

As you do not have Committer status in this project, an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@edvbld) but any other Committer may sponsor as well.

  • To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Aug 26, 2019
@lkorinth
Copy link
Author

@lkorinth lkorinth commented Aug 26, 2019

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Aug 26, 2019

@lkorinth
Your change (at version 372c4e9) is now ready to be sponsored by a Committer.

@openjdk openjdk bot added the sponsor label Aug 26, 2019
@edvbld
Copy link
Member

@edvbld edvbld commented Aug 26, 2019

/sponsor

@openjdk openjdk bot closed this Aug 26, 2019
@openjdk
Copy link

@openjdk openjdk bot commented Aug 26, 2019

@edvbld @lkorinth The following commits have been pushed to master since your change was applied:

Your commit was automatically rebased without conflicts.
Pushed as commit e8e2f0e.

@openjdk openjdk bot added the integrated label Aug 26, 2019
@lkorinth lkorinth deleted the _rev2 branch Aug 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants