Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vcs: better regex for real names #815

Closed
wants to merge 1 commit into from

Conversation

edvbld
Copy link
Member

@edvbld edvbld commented Sep 11, 2020

Hi all,

please review this patch that makes the real name regular expression in the commit message parser accept essentially all characters except the one used in e-mail addresses.

Testing:

  • Added a new unit test
  • make test passes on Linux x64

Thanks,
Erik


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Reviewers

Download

$ git fetch https://git.openjdk.java.net/skara pull/815/head:pull/815
$ git checkout pull/815

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 11, 2020

👋 Welcome back ehelin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Sep 11, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 11, 2020

@edvbld To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request.

In order to have an RFR email automatically sent to the correct mailing list, you will need to add one or more labels manually using the /label add "label" command. The following labels are valid: bots build cli libs skara-dev skara-extra.

Copy link
Member

@rwestberg rwestberg left a comment

Looks good!

@edvbld
Copy link
Member Author

@edvbld edvbld commented Sep 11, 2020

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Sep 11, 2020

@edvbld This change now passes all automated pre-integration checks. In addition to the automated checks, the change must also fulfill all project specific requirements

After integration, the commit message will be:

vcs: better regex for real names

Reviewed-by: rwestberg
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there have been 3 commits pushed to the master branch:

  • b59316d: Treat bad whitespace in commit message gracefully
  • 8806fe5: 616: Sponsorship information is incorrect.
  • de0ffaa: 634: Refresh PR data between commands in CommandWorkItem

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate b59316d0493dc2030e1e1552ad19cbe7cba516ac.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Sep 11, 2020
@openjdk openjdk bot closed this Sep 11, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 11, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 11, 2020

@edvbld Since your change was applied there have been 3 commits pushed to the master branch:

  • b59316d: Treat bad whitespace in commit message gracefully
  • 8806fe5: 616: Sponsorship information is incorrect.
  • de0ffaa: 634: Refresh PR data between commands in CommandWorkItem

Your commit was automatically rebased without conflicts.

Pushed as commit 5c7b36e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 11, 2020

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants