Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set or update the resolved in build field when new tags arrive #817

Closed
wants to merge 3 commits into from

Conversation

rwestberg
Copy link
Member

@rwestberg rwestberg commented Sep 14, 2020

When the issue notifier is configured to set a build name when resolving issues, it should also update that name when an OpenJDK-formatted tag is seen in the repository.


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Reviewers

Download

$ git fetch https://git.openjdk.java.net/skara pull/817/head:pull/817
$ git checkout pull/817

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 14, 2020

👋 Welcome back rwestberg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Sep 14, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 14, 2020

@rwestberg The following label will be automatically applied to this pull request: bots.

When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label (add|remove) "label" command.

@openjdk openjdk bot added the bots label Sep 14, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 14, 2020

Webrevs

edvbld
edvbld approved these changes Sep 14, 2020
Copy link
Member

@edvbld edvbld left a comment

Looks good, just spell out "rib" in two places 😉

@openjdk
Copy link

@openjdk openjdk bot commented Sep 14, 2020

@rwestberg This change now passes all automated pre-integration checks. In addition to the automated checks, the change must also fulfill all project specific requirements

After integration, the commit message will be:

Set or update the resolved in build field when new tags arrive

Reviewed-by: ehelin
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there have been 2 commits pushed to the master branch:

  • b86ed56: 672: Support pulling tags in checkout bot
  • 4d2fa4a: jcheck: use census from .jcheck/conf by default

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate b86ed562b21979299c9a45adfd735a2aa88a0bb6.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Sep 14, 2020
Robin Westberg and others added 2 commits Sep 15, 2020
@rwestberg
Copy link
Member Author

@rwestberg rwestberg commented Sep 15, 2020

/integrate

@openjdk openjdk bot closed this Sep 15, 2020
@openjdk openjdk bot added integrated and removed ready labels Sep 15, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 15, 2020

@rwestberg Since your change was applied there have been 2 commits pushed to the master branch:

  • b86ed56: 672: Support pulling tags in checkout bot
  • 4d2fa4a: jcheck: use census from .jcheck/conf by default

Your commit was automatically rebased without conflicts.

Pushed as commit 9dd7150.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@openjdk openjdk bot removed the rfr label Sep 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants