672: Support pulling tags in checkout bot

[edvbld]

Hi all,

please review this patch that allows the checkout bot to support pulling tags. To achieve this I updated Repository.pull to take an explicit includeTags argument.

Testing:

• make test passes on Linux x64
• Added a new unit test

Thanks,
Erik

---

Progress

• Change must not contain extraneous whitespace
• Change must be properly reviewed

Issue

• SKARA-672: Support pulling tags in checkout bot

Reviewers

• Robin Westberg (@rwestberg - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/skara pull/819/head:pull/819
$ git checkout pull/819

[bridgekeeper]

👋 Welcome back ehelin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@edvbld The following label will be automatically applied to this pull request: bots.

When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label (add|remove) "label" command.

[mlbridge]

Webrevs

• 00: Full (de8f63d)

[rwestberg]

Looks good! Perhaps you could add an issue for this so that we see that the resolved in build functionality works. :)

[openjdk]

@edvbld This change now passes all automated pre-integration checks. In addition to the automated checks, the change must also fulfill all project specific requirements

After integration, the commit message will be:

672: Support pulling tags in checkout bot

Reviewed-by: rwestberg

• If you would like to add a summary, use the /summary command.
• To credit additional contributors, use the /contributor command.
• To add additional solved issues, use the /issue command.

There are currently no new commits on the master branch since the last update of the source branch of this PR. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you would like to avoid potential automatic rebasing, specify the current head hash when integrating, like this: /integrate 4d2fa4aa15fae673356c4b667bb1b4c843c51c58.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[edvbld]

/issue add 672

[openjdk]

@edvbld The primary solved issue for a PR is set through the PR title. Since the current title does not contain an issue reference, it will now be updated.

[edvbld]

/integrate

[openjdk]

@edvbld Pushed as commit b86ed56.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.