Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

648: git sync requires ssh to be specified when setting 'to' repo on set-up #827

Closed
wants to merge 1 commit into from

Conversation

edvbld
Copy link
Member

@edvbld edvbld commented Sep 17, 2020

Hi all,

please review this patch that makes git-sync work better with git-style SSH paths.

Testing:

  • Manual testing on Linux x64

Thanks,
Erik


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Issue

  • SKARA-648: git sync requires ssh to be specified when setting 'to' repo on set-up

Reviewers

Download

$ git fetch https://git.openjdk.java.net/skara pull/827/head:pull/827
$ git checkout pull/827

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 17, 2020

👋 Welcome back ehelin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 648 648: git sync requires ssh to be specified when setting 'to' repo on set-up Sep 17, 2020
@openjdk openjdk bot added the rfr label Sep 17, 2020
@openjdk
Copy link

openjdk bot commented Sep 17, 2020

@edvbld The following label will be automatically applied to this pull request: cli.

When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label (add|remove) "label" command.

@openjdk openjdk bot added the cli label Sep 17, 2020
Copy link
Member

@rwestberg rwestberg left a comment

Looks good!

@openjdk
Copy link

openjdk bot commented Sep 17, 2020

@edvbld This change now passes all automated pre-integration checks. In addition to the automated checks, the change must also fulfill all project specific requirements

After integration, the commit message will be:

648: `git sync` requires ssh to be specified when setting 'to' repo on set-up

Reviewed-by: rwestberg
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there has been 1 commit pushed to the master branch:

  • d7cdb98: 689: Do not automatically adjust labels after users intervenes

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate d7cdb985412682ddb90d3a1d5a693825a0b027fc.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Sep 17, 2020
@mlbridge
Copy link

mlbridge bot commented Sep 17, 2020

Webrevs

@edvbld
Copy link
Member Author

edvbld commented Sep 17, 2020

/integrate

@openjdk openjdk bot closed this Sep 17, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 17, 2020
@openjdk
Copy link

openjdk bot commented Sep 17, 2020

@edvbld Since your change was applied there has been 1 commit pushed to the master branch:

  • d7cdb98: 689: Do not automatically adjust labels after users intervenes

Your commit was automatically rebased without conflicts.

Pushed as commit 44ceeb7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants