Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

692: Improve integration message #828

Closed
wants to merge 4 commits into from

Conversation

rwestberg
Copy link
Member

@rwestberg rwestberg commented Sep 17, 2020

Update the integration ready message slightly in response to feedback.

Best regards,
Robin


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Issue

Reviewers

Download

$ git fetch https://git.openjdk.java.net/skara pull/828/head:pull/828
$ git checkout pull/828

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 17, 2020

👋 Welcome back rwestberg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 692 692: Improve integration message Sep 17, 2020
@openjdk openjdk bot added the rfr label Sep 17, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 17, 2020

@rwestberg The following label will be automatically applied to this pull request: bots.

When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label (add|remove) "label" command.

@openjdk openjdk bot added the bots label Sep 17, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 17, 2020

Webrevs

edvbld
edvbld approved these changes Sep 17, 2020
Copy link
Member

@edvbld edvbld left a comment

Looks good, just one more test to fix!

@openjdk
Copy link

@openjdk openjdk bot commented Sep 17, 2020

@rwestberg This change now passes all automated pre-integration checks. In addition to the automated checks, the change must also fulfill all project specific requirements

After integration, the commit message will be:

692: Improve integration message

Reviewed-by: ehelin
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there have been 2 commits pushed to the master branch:

  • fa98950: 649: SKARA will not build/install without termcap
  • ca3795d: 683: Stats entry in automatic integration email swaps insertions and deletions

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate fa989500e0d8011a960f6bcd8fccd884c8900848.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Sep 17, 2020
@rwestberg
Copy link
Member Author

@rwestberg rwestberg commented Sep 18, 2020

/integrate

@openjdk openjdk bot closed this Sep 18, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 18, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 18, 2020

@rwestberg Since your change was applied there have been 2 commits pushed to the master branch:

  • fa98950: 649: SKARA will not build/install without termcap
  • ca3795d: 683: Stats entry in automatic integration email swaps insertions and deletions

Your commit was automatically rebased without conflicts.

Pushed as commit ae829d6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants