Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

649: SKARA will not build/install without termcap #830

Closed
wants to merge 1 commit into from

Conversation

@edvbld
Copy link
Member

@edvbld edvbld commented Sep 17, 2020

Hi all,

please review this small patch that makes us fall back to TERM=dumb if TERM is not specified when building on Linux.

Testing:

  • make works on Linux x64 with and without TERM defined

Thanks,
Erik


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Issue

  • SKARA-649: SKARA will not build/install without termcap

Reviewers

Download

$ git fetch https://git.openjdk.java.net/skara pull/830/head:pull/830
$ git checkout pull/830

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 17, 2020

👋 Welcome back ehelin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 649 649: SKARA will not build/install without termcap Sep 17, 2020
@openjdk openjdk bot added the rfr label Sep 17, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 17, 2020

@edvbld The following label will be automatically applied to this pull request: build.

When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label (add|remove) "label" command.

@openjdk openjdk bot added the build label Sep 17, 2020
Copy link
Member

@rwestberg rwestberg left a comment

Looks good!

@openjdk
Copy link

@openjdk openjdk bot commented Sep 17, 2020

@edvbld This change now passes all automated pre-integration checks. In addition to the automated checks, the change must also fulfill all project specific requirements

After integration, the commit message will be:

649: SKARA will not build/install without termcap

Reviewed-by: rwestberg
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

There are currently no new commits on the master branch since the last update of the source branch of this PR. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you would like to avoid potential automatic rebasing, specify the current head hash when integrating, like this: /integrate ca3795d2cde73b5eb5228eddc60ccb963f940b59.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Sep 17, 2020
@edvbld
Copy link
Member Author

@edvbld edvbld commented Sep 17, 2020

/integrate

@openjdk openjdk bot closed this Sep 17, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 17, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 17, 2020

@edvbld Pushed as commit fa98950.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 17, 2020

Webrevs

@@ -188,6 +188,7 @@ if [ "${OS}" = "Linux" ]; then
export LC_ALL=en_US.UTF-8
export LANG=en_US.UTF-8
export LANGUAGE=en_US.UTF-8
export TERM=${TERM:-dumb}
Copy link
Member

@phedlin phedlin Sep 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TERM=dumb will work as a workaround (dropping the fancy progress bar) but TERM not being set is not the proper condition for lack of termcap support (e.g. when terminfo is used and TERM set accordingly).

Copy link
Member Author

@edvbld edvbld Sep 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@phedlin I'm not sure that there is a way to determine whether a process uses termcap or terminfo, do you know of a reliable way? I think the best we can do here is to add some documentation to README.md, instructing the user to run sh gradlew --console=plain as a workaround. Or do you have any other suggestions?

Copy link
Member Author

@edvbld edvbld Sep 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@phedlin I might have a way to default to --console=plain while still allowing Skara developers to opt-in to a more fancy console. Can you please try building with sh gradlew --console=plain and see if it works on your system?

Copy link
Member

@phedlin phedlin Sep 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JAVA_HOME=~/local/jdk14-import/build/linux-aarch64/images/jdk sh ./gradlew --console=plain

FAILURE: Build failed with an exception.

* What went wrong:
Could not open terminal for stdout: could not get termcap entry

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants