Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TERM=dumb will work as a workaround (dropping the fancy progress bar) but TERM not being set is not the proper condition for lack of termcap support (e.g. when terminfo is used and TERM set accordingly).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@phedlin I'm not sure that there is a way to determine whether a process uses
termcap
orterminfo
, do you know of a reliable way? I think the best we can do here is to add some documentation toREADME.md
, instructing the user to runsh gradlew --console=plain
as a workaround. Or do you have any other suggestions?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@phedlin I might have a way to default to
--console=plain
while still allowing Skara developers to opt-in to a more fancy console. Can you please try building withsh gradlew --console=plain
and see if it works on your system?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.