Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

710: Map share/utilities to hotspot-dev #832

Closed
wants to merge 1 commit into from

Conversation

@stefank
Copy link
Member

@stefank stefank commented Sep 21, 2020

PRs for changes to share/utilities go to hotspot-runtime. This is incorrect, since share/utilities is shared among the teams.


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Issue

  • SKARA-710: Map share/utilities to hotspot-dev

Reviewers

Download

$ git fetch https://git.openjdk.java.net/skara pull/832/head:pull/832
$ git checkout pull/832

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 21, 2020

👋 Welcome back stefank! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Sep 21, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 21, 2020

@stefank To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request.

In order to have an RFR email automatically sent to the correct mailing list, you will need to add one or more labels manually using the /label add "label" command. The following labels are valid: bots build cli libs skara-dev skara-extra.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 21, 2020

Webrevs

@stefank
Copy link
Member Author

@stefank stefank commented Sep 21, 2020

/label add bots

@openjdk openjdk bot added the bots label Sep 21, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 21, 2020

@stefank
The bots label was successfully added.

Copy link
Member

@rwestberg rwestberg left a comment

Looks good, thanks for updating!

@openjdk
Copy link

@openjdk openjdk bot commented Sep 21, 2020

@stefank This change now passes all automated pre-integration checks. In addition to the automated checks, the change must also fulfill all project specific requirements

After integration, the commit message will be:

710: Map share/utilities to hotspot-dev

Reviewed-by: rwestberg
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there have been 4 commits pushed to the master branch:

  • b69b6d2: 657: Integrate command uses "merge request" in failure message
  • 72317c6: 663: Bad URL in PR created by openjdk-bot in responnse to merge conflict
  • 36edd9e: 548: PR is marked as being ready for integration before the CSR is approved
  • 12b9328: defpath: normalize error format

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate b69b6d2640cf2a203ef3d4b12e15704e01c587ee.

As you do not have Committer status in this projectan existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@rwestberg) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Sep 21, 2020
@stefank
Copy link
Member Author

@stefank stefank commented Sep 22, 2020

/integrate

@openjdk openjdk bot added the sponsor label Sep 22, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 22, 2020

@stefank
Your change (at version 0bf6abc) is now ready to be sponsored by a Committer.

@rwestberg
Copy link
Member

@rwestberg rwestberg commented Sep 22, 2020

/sponsor

@openjdk openjdk bot closed this Sep 22, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 22, 2020

@rwestberg @stefank Since your change was applied there have been 4 commits pushed to the master branch:

  • b69b6d2: 657: Integrate command uses "merge request" in failure message
  • 72317c6: 663: Bad URL in PR created by openjdk-bot in responnse to merge conflict
  • 36edd9e: 548: PR is marked as being ready for integration before the CSR is approved
  • 12b9328: defpath: normalize error format

Your commit was automatically rebased without conflicts.

Pushed as commit 4f170e4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@openjdk openjdk bot removed the rfr label Sep 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants