Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

694: Checking invalid email gives an exception #837

Closed
wants to merge 2 commits into from
Closed

Conversation

@edvbld
Copy link
Member

@edvbld edvbld commented Sep 21, 2020

Hi all,

please review this patch that ensures that contributors who do not have an OpenJDK username specify a valid name and e-mail for a pull request's HEAD commit.

Testing:

  • Added a new unit test
  • make test passes on Linux x64

Thanks,
Erik


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Issue

  • SKARA-694: Checking invalid email gives an exception

Reviewers

Download

$ git fetch https://git.openjdk.java.net/skara pull/837/head:pull/837
$ git checkout pull/837

694
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 21, 2020

👋 Welcome back ehelin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 694 694: Checking invalid email gives an exception Sep 21, 2020
@openjdk openjdk bot added the rfr label Sep 21, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 21, 2020

@edvbld The following label will be automatically applied to this pull request: bots.

When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label (add|remove) "label" command.

@openjdk openjdk bot added the bots label Sep 21, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 21, 2020

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented Sep 21, 2020

@edvbld This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for more details.

After integration, the commit message for the final commit will be:

694: Checking invalid email gives an exception

Reviewed-by: tbell, rwestberg

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • 179f923: 716: Git version check pattern matching is too strict
  • 4f170e4: 710: Map share/utilities to hotspot-dev
  • b69b6d2: 657: Integrate command uses "merge request" in failure message
  • 72317c6: 663: Bad URL in PR created by openjdk-bot in responnse to merge conflict

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Sep 21, 2020
Copy link
Member

@rwestberg rwestberg left a comment

Looks good!

@edvbld
Copy link
Member Author

@edvbld edvbld commented Sep 22, 2020

/integrate

@openjdk openjdk bot closed this Sep 22, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 22, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 22, 2020

@edvbld Since your change was applied there have been 4 commits pushed to the master branch:

  • 179f923: 716: Git version check pattern matching is too strict
  • 4f170e4: 710: Map share/utilities to hotspot-dev
  • b69b6d2: 657: Integrate command uses "merge request" in failure message
  • 72317c6: 663: Bad URL in PR created by openjdk-bot in responnse to merge conflict

Your commit was automatically rebased without conflicts.

Pushed as commit dc524c1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants