Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

716: Git version check pattern matching is too strict #838

wants to merge 1 commit into from
Changes from all commits
File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.


Just for now

@@ -32,7 +32,7 @@
public class GitVersion {

private static final Pattern versionPattern = Pattern.compile(
"git version (?<versionString>.*(?<major>\\d)\\.(?<minor>\\d{2})\\.(?<security>\\d).*)");
"git version (?<versionString>.*(?<major>\\d+)\\.(?<minor>\\d+)\\.(?<security>\\d+).*)");
private static final GitVersion UNKNOWN = new GitVersion("UNKNOWN", -1, -1, -1);

private final String versionString;
ProTip! Use n and p to navigate between commits in a pull request.