Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit path arguments to git to 64 at a time #84

Closed
wants to merge 1 commit into from

Conversation

edvbld
Copy link
Member

@edvbld edvbld commented Aug 26, 2019

Hi all,

this commit limits the number of Path arguments we pass on to git to at most 64 at a time. This is too avoid too long command lines (since paths can be fairly long).

Testing

  • sh gradlew test passes

Thanks,
Erik

Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Approvers

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 26, 2019

👋 Welcome back ehelin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request (refresh this page to view it).

@openjdk openjdk bot added the rfr label Aug 26, 2019
@mlbridge
Copy link

mlbridge bot commented Aug 26, 2019

Webrevs

Copy link
Member

@rwestberg rwestberg left a comment

Looks good!

@openjdk openjdk bot removed the rfr label Aug 26, 2019
@openjdk
Copy link

openjdk bot commented Aug 26, 2019

@edvbld This change can now be integrated. The commit message will be:

Limit path arguments to git to 64 at a time

Reviewed-by: rwestberg
  • If you would like to add a summary, use the /summary command.
  • To list additional contributors, use the /contributor command.
  • To integrate this PR with the above commit message, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Aug 26, 2019
@edvbld
Copy link
Member Author

edvbld commented Aug 26, 2019

/integrate

@openjdk openjdk bot closed this Aug 26, 2019
@openjdk openjdk bot added the integrated label Aug 26, 2019
@openjdk
Copy link

openjdk bot commented Aug 26, 2019

@edvbld Pushed as commit 4e470d8.

@edvbld edvbld deleted the batch branch Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants