Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

685: Show a warning if PR author's full name does not match commit author's full name #840

Closed
wants to merge 1 commit into from

Conversation

edvbld
Copy link
Member

@edvbld edvbld commented Sep 22, 2020

Hi all,

please review this patch that adds an error if the author of the pull request does not have an OpenJDK username, has a full name set for their GitHub account and the HEAD commit for the pull request uses another full name.

Testing:

  • make test passes on Linux x64
  • Added an additional unit test

Thanks,
Erik


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Issue

  • SKARA-685: Show a warning if PR author's full name does not match commit author's full name

Reviewers

Download

$ git fetch https://git.openjdk.java.net/skara pull/840/head:pull/840
$ git checkout pull/840

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 22, 2020

👋 Welcome back ehelin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 685 685: Show a warning if PR author's full name does not match commit author's full name Sep 22, 2020
@openjdk openjdk bot added the rfr label Sep 22, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 22, 2020

@edvbld The following label will be automatically applied to this pull request: bots.

When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label (add|remove) "label" command.

@openjdk openjdk bot added the bots label Sep 22, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 22, 2020

Webrevs

Copy link
Member

@rwestberg rwestberg left a comment

Looks good!

@openjdk
Copy link

@openjdk openjdk bot commented Sep 23, 2020

@edvbld This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for more details.

After integration, the commit message for the final commit will be:

685: Show a warning if PR author's full name does not match commit author's full name

Reviewed-by: rwestberg

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • e80a5d4: 623: Label rules filter should take direct group matches into account

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Sep 23, 2020
@edvbld
Copy link
Member Author

@edvbld edvbld commented Sep 23, 2020

/integrate

@openjdk openjdk bot closed this Sep 23, 2020
@openjdk openjdk bot added integrated and removed ready labels Sep 23, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 23, 2020

@edvbld Since your change was applied there has been 1 commit pushed to the master branch:

  • e80a5d4: 623: Label rules filter should take direct group matches into account

Your commit was automatically rebased without conflicts.

Pushed as commit 72b87eb.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@openjdk openjdk bot removed the rfr label Sep 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants