Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Special domain for OpenJDK Contributors is openjdk.org #85

Closed
wants to merge 1 commit into from

Conversation

edvbld
Copy link
Member

@edvbld edvbld commented Aug 26, 2019

Hi all,

as part of the last re-coversion the special domain used to recognize OpenJDK Contributors changed from openjdk.java.net to openjdk.org. This patch updates the backwards compatible interpretation of .jcheck/conf to use openjdk.org correctly.

Testing

  • sh gradlew test passes on Linux x86_64

Thanks,
Erik

Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Approvers

@edvbld edvbld changed the title Default domain for the jdk repo is openjdk.org Special domain OpenJDK Contributors is is openjdk.org Aug 26, 2019
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Aug 26, 2019

👋 Welcome back ehelin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request (refresh this page to view it).

@openjdk openjdk bot added the rfr label Aug 26, 2019
@edvbld edvbld changed the title Special domain OpenJDK Contributors is is openjdk.org Special domain for OpenJDK Contributors is openjdk.org Aug 26, 2019
Copy link
Member

@rwestberg rwestberg left a comment

Looks fine!

@mlbridge
Copy link

@mlbridge mlbridge bot commented Aug 26, 2019

Webrevs

@openjdk openjdk bot removed the rfr label Aug 26, 2019
@openjdk
Copy link

@openjdk openjdk bot commented Aug 26, 2019

@edvbld This change can now be integrated. The commit message will be:

Special domain for OpenJDK Contributors is openjdk.org

Reviewed-by: rwestberg
  • If you would like to add a summary, use the /summary command.
  • To list additional contributors, use the /contributor command.
  • To integrate this PR with the above commit message, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Aug 26, 2019
@edvbld
Copy link
Member Author

@edvbld edvbld commented Aug 26, 2019

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Aug 26, 2019

@edvbld Your merge request cannot be fulfilled at this time, as the status check jcheck is still in progress

@edvbld
Copy link
Member Author

@edvbld edvbld commented Aug 26, 2019

/integrate

@kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Aug 26, 2019

Looks good to me, too. I'll test it once you've pushed.

@openjdk openjdk bot closed this Aug 26, 2019
@openjdk openjdk bot added the integrated label Aug 26, 2019
@openjdk
Copy link

@openjdk openjdk bot commented Aug 26, 2019

@edvbld Pushed as commit 7dbc76d.

@edvbld
Copy link
Member Author

@edvbld edvbld commented Aug 26, 2019

@kevinrushforth pushed 😉

@kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Aug 26, 2019

Thanks. I tested it and it works for me.

@edvbld edvbld deleted the openjdk.org branch Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants