forge: add search method

[edvbld]

Hi all,

please review this patch that adds the Forge.search method to allow searching for a commit with a particular hash on a forge.

Thanks,
Erik

---

Progress

• Change must not contain extraneous whitespace
• Change must be properly reviewed

Reviewers

• Robin Westberg (@rwestberg - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/skara pull/854/head:pull/854
$ git checkout pull/854

[bridgekeeper]

👋 Welcome back ehelin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@edvbld The following label will be automatically applied to this pull request:

• bots

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (1bc74d8)

[rwestberg]

Looks good, a bit worried that auto-pagination of thousands of commits will take a while though.. :)

[rwestberg]

Could we use this endpoint instead? https://docs.gitlab.com/ce/api/commits.html#get-a-single-commit

[edvbld]

That is the endpoint the code is using 😸 Did you perhaps miss the + hex part?

[rwestberg]

Well then, carry on!

[edvbld]

Looks good, a bit worried that auto-pagination of thousands of commits will take a while though.. :)

Since we are limiting the GitHub search to selected organizations, we should for the https://github.com/openjdk organization get at most O(#repos) results (a commit can exist at most once in a repo).

[openjdk]

@edvbld This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for more details.

After integration, the commit message for the final commit will be:

forge: add search method

Reviewed-by: rwestberg

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[edvbld]

/integrate

[openjdk]

@edvbld Since your change was applied there has been 1 commit pushed to the master branch:

• f023a34: update-sync labels should be applied to all-bar-one records

Your commit was automatically rebased without conflicts.

Pushed as commit 10f3a1f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.