Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show a summary of pre-submit testing results in the PR body (if any) #855

Closed
wants to merge 3 commits into from

Conversation

@rwestberg
Copy link
Member

@rwestberg rwestberg commented Sep 30, 2020

Now that we are executing pre-submit tests for certain OpenJDK repositories, we can also display a summary of the results in the PR body, to help reviewers determine the test status of a change.


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Reviewers

Download

$ git fetch https://git.openjdk.java.net/skara pull/855/head:pull/855
$ git checkout pull/855

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 30, 2020

👋 Welcome back rwestberg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Sep 30, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 30, 2020

@rwestberg The following label will be automatically applied to this pull request:

  • bots

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the bots label Sep 30, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 30, 2020

Webrevs

@edvbld
edvbld approved these changes Sep 30, 2020
Copy link
Member

@edvbld edvbld left a comment

Wow, very nice!

@openjdk
Copy link

@openjdk openjdk bot commented Sep 30, 2020

@rwestberg This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for more details.

After integration, the commit message for the final commit will be:

Show a summary of pre-submit testing results in the PR body (if any)

Reviewed-by: ehelin

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

  • 3a8e317: Avoid potentially moving folders across volume boundaries
  • 4678f1a: Ensure that spurious newlines added by the hosted provider does not give different metadata checksums
  • 10f3a1f: forge: add search method
  • f023a34: update-sync labels should be applied to all-bar-one records
  • 606b40c: Fix the TestBot concurrency improvement

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Sep 30, 2020
@rwestberg
Copy link
Member Author

@rwestberg rwestberg commented Oct 5, 2020

/integrate

@openjdk openjdk bot closed this Oct 5, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Oct 5, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Oct 5, 2020

@rwestberg Since your change was applied there have been 5 commits pushed to the master branch:

  • 3a8e317: Avoid potentially moving folders across volume boundaries
  • 4678f1a: Ensure that spurious newlines added by the hosted provider does not give different metadata checksums
  • 10f3a1f: forge: add search method
  • f023a34: update-sync labels should be applied to all-bar-one records
  • 606b40c: Fix the TestBot concurrency improvement

Your commit was automatically rebased without conflicts.

Pushed as commit 343c512.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants