Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that spurious newlines added by the hosted provider does not give different metadata checksums #857

Closed
wants to merge 1 commit into from

Conversation

rwestberg
Copy link
Member

@rwestberg rwestberg commented Oct 1, 2020

At least for GitLab, the body of a pull request can be amended server side with additional newlines. Ensure that this does not affect the metadata calculation.


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Reviewers

Download

$ git fetch https://git.openjdk.java.net/skara pull/857/head:pull/857
$ git checkout pull/857

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 1, 2020

👋 Welcome back rwestberg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Oct 1, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Oct 1, 2020

@rwestberg The following label will be automatically applied to this pull request:

  • bots

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the bots label Oct 1, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 1, 2020

Webrevs

edvbld
edvbld approved these changes Oct 5, 2020
Copy link
Member

@edvbld edvbld left a comment

Looks good!

@openjdk
Copy link

@openjdk openjdk bot commented Oct 5, 2020

@rwestberg This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for more details.

After integration, the commit message for the final commit will be:

Ensure that spurious newlines added by the hosted provider does not give different metadata checksums

Reviewed-by: ehelin

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Oct 5, 2020
@rwestberg
Copy link
Member Author

@rwestberg rwestberg commented Oct 5, 2020

/integrate

@openjdk openjdk bot closed this Oct 5, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Oct 5, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Oct 5, 2020

@rwestberg Pushed as commit 4678f1a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants