Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid potentially moving folders across volume boundaries #858

wants to merge 1 commit into from


Copy link

@rwestberg rwestberg commented Oct 2, 2020

When a checked out repository cannot be cleaned, the folder is moved to a separate location to allow further manual inspection. Avoid moving them across volume boundaries.


  • Change must not contain extraneous whitespace
  • Change must be properly reviewed



$ git fetch pull/858/head:pull/858
$ git checkout pull/858

Copy link

@bridgekeeper bridgekeeper bot commented Oct 2, 2020

👋 Welcome back rwestberg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Oct 2, 2020
Copy link

@mlbridge mlbridge bot commented Oct 2, 2020


edvbld approved these changes Oct 5, 2020
Copy link

@edvbld edvbld left a comment

Looks good!

Copy link

@openjdk openjdk bot commented Oct 5, 2020

@rwestberg This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file for more details.

After integration, the commit message for the final commit will be:

Avoid potentially moving folders across volume boundaries

Reviewed-by: ehelin

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Oct 5, 2020
Copy link
Member Author

@rwestberg rwestberg commented Oct 5, 2020


@openjdk openjdk bot closed this Oct 5, 2020
@openjdk openjdk bot added integrated and removed ready labels Oct 5, 2020
Copy link

@openjdk openjdk bot commented Oct 5, 2020

@rwestberg Since your change was applied there has been 1 commit pushed to the master branch:

  • 4678f1a: Ensure that spurious newlines added by the hosted provider does not give different metadata checksums

Your commit was automatically rebased without conflicts.

Pushed as commit 3a8e317.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@openjdk openjdk bot removed the rfr label Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants