Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

756: Fix action platform names #863

Closed
wants to merge 1 commit into from

Conversation

rwestberg
Copy link
Member

@rwestberg rwestberg commented Oct 6, 2020

The latest update to the GitHub Actions file accidentally swapped windows and mac.


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Testing

Linux x64 Windows x64 macOS x64
Build / test ✔️ (1/1 passed) ✔️ (1/1 passed) ✔️ (1/1 passed)

Issue

Reviewers

Download

$ git fetch https://git.openjdk.java.net/skara pull/863/head:pull/863
$ git checkout pull/863

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 6, 2020

👋 Welcome back rwestberg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Oct 6, 2020
@rwestberg
Copy link
Member Author

@rwestberg rwestberg commented Oct 6, 2020

/issue create

@openjdk
Copy link

@openjdk openjdk bot commented Oct 6, 2020

@rwestberg Command syntax:

  • /issue [add|remove] <id>[,<id>,...]
  • /issue [add] <id>: <description>
  • `/issue create [PX] /[subcomponent]

Some examples:

  • /issue add JDK-1234567,4567890
  • /issue remove JDK-4567890
  • /issue 1234567: Use this exact title
  • `/issue create hotspot/jfr
  • `/issue create P4 core-libs/java.nio

If issues are specified only by their ID, the title will be automatically retrieved from JBS. The project prefix (JDK- in the above examples) is optional. Separate multiple issue IDs using either spaces or commas.

@rwestberg
Copy link
Member Author

@rwestberg rwestberg commented Oct 6, 2020

/issue create admin

@openjdk openjdk bot changed the title Fix action platform names 756: Fix action platform names Oct 6, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Oct 6, 2020

@rwestberg The issue SKARA-756 was successfully created - the title of this PR will be updated to reference it.

@rwestberg rwestberg changed the title 756: Fix action platform names 756: Mismatch with fix action platform names Oct 6, 2020
@rwestberg rwestberg changed the title 756: Mismatch with fix action platform names 756: Fix action platform names Oct 6, 2020
edvbld
edvbld approved these changes Oct 6, 2020
Copy link
Member

@edvbld edvbld left a comment

Looks good 👍

@openjdk
Copy link

@openjdk openjdk bot commented Oct 6, 2020

@rwestberg This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

756: Fix action platform names

Reviewed-by: ehelin

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 4095042: Store the check expiration info in the metadata

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Oct 6, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 6, 2020

Webrevs

@rwestberg
Copy link
Member Author

@rwestberg rwestberg commented Oct 7, 2020

/integrate

@openjdk openjdk bot closed this Oct 7, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Oct 7, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Oct 7, 2020

@rwestberg Since your change was applied there has been 1 commit pushed to the master branch:

  • 4095042: Store the check expiration info in the metadata

Your commit was automatically rebased without conflicts.

Pushed as commit c31b1a9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

openjdk-notifier bot referenced this issue Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants