Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pr: introduce backport pull requests #868

Closed
wants to merge 1 commit into from

Conversation

edvbld
Copy link
Member

@edvbld edvbld commented Oct 7, 2020

Hi all,

please review this patch that introduces the concepts of "backport style" pull requests. If a pull request title matches Backport <hash> then issues and summaries from <hash> will be added to the current pull request. If the "backport style" pull request is integrated then a Backport-of: <hash> trailer will also be automatically added to the commit message.

Testing:

  • Added four new unit tests
  • make test passes on Linux x64

Thanks,
Erik


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Testing

Linux x64 Windows x64 macOS x64
Build / test (1/1 running) (1/1 running) ✔️ (1/1 passed)

Reviewers

Download

$ git fetch https://git.openjdk.java.net/skara pull/868/head:pull/868
$ git checkout pull/868

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 7, 2020

👋 Welcome back ehelin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Oct 7, 2020
Copy link
Member

@rwestberg rwestberg left a comment

Looks good!

@openjdk
Copy link

@openjdk openjdk bot commented Oct 7, 2020

@edvbld This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

pr: introduce backport pull requests

Reviewed-by: rwestberg

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

  • 7c414b5: Cache check expiration times
  • 71b68ca: Avoid checking closed PRs, handle the "skipped" state of a GitHub check
  • 15f2b46: Metadata cache expiration makes the generic expiration in the PR update cache unnecessary
  • c31b1a9: 756: Fix action platform names
  • 4095042: Store the check expiration info in the metadata
  • 49cddf4: Add support for marking PR body content with an expiration time

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Oct 7, 2020
@edvbld
Copy link
Member Author

@edvbld edvbld commented Oct 7, 2020

/integrate

@openjdk openjdk bot closed this Oct 7, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Oct 7, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Oct 7, 2020

@edvbld Since your change was applied there have been 6 commits pushed to the master branch:

  • 7c414b5: Cache check expiration times
  • 71b68ca: Avoid checking closed PRs, handle the "skipped" state of a GitHub check
  • 15f2b46: Metadata cache expiration makes the generic expiration in the PR update cache unnecessary
  • c31b1a9: 756: Fix action platform names
  • 4095042: Store the check expiration info in the metadata
  • 49cddf4: Add support for marking PR body content with an expiration time

Your commit was automatically rebased without conflicts.

Pushed as commit 26e6b8b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 7, 2020

Webrevs

openjdk-notifier bot referenced this issue Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants