New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial implementation of dependent pull requests #886
Conversation
|
Webrevs
|
@rwestberg This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 3 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the
|
/integrate |
@rwestberg Since your change was applied there have been 3 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit f38ef5a. |
This is the initial implementation of the support for creating a follow-up pull request while the first one is still out for review. This will allow having multiple dependent changes out for review simultaneously, which is something that was possible during the hg/webrev era.
To use it, first create a pull request from the first change. In that pull request, issue the
/preintegrate
command. This will publish the current contents to a new branch in the target repository namedpr/<username>/<pr-id>
. Now any follow-up work can target this branch instead, which contains the dependent work.When the first pull request is
/integrate
d, any follow-up pull requests will automatically be retargeted to the original target branch. It will not be possible to/integrate
the follow-up pull request until the first one has been integrated.Progress
Testing
Reviewers
Download
$ git fetch https://git.openjdk.java.net/skara pull/886/head:pull/886
$ git checkout pull/886