Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

forge: add HostedRepository.recentCommitComments #891

Closed
wants to merge 3 commits into from

Conversation

edvbld
Copy link
Member

@edvbld edvbld commented Oct 19, 2020

Hi all,

please review this patch that adds the method HostedRepository.recentCommitComments for fetching recent commit comments. "Recent" is somewhat fuzzy and is up to the forge to decide, because the REST APIs for GitHub and GitLab are very different for retrieving recent commit comments. The GitLab REST API in particular is a bit annoying since it doesn't provide a noteable_id with the commit's hash for commit comment events. I therefore hade to make CommitComment support lazily fetching the hash for the commit.

Thanks,
Erik


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Testing

Linux x64 Windows x64 macOS x64
Build / test ✔️ (1/1 passed) ✔️ (1/1 passed) ✔️ (1/1 passed)

Reviewers

Download

$ git fetch https://git.openjdk.java.net/skara pull/891/head:pull/891
$ git checkout pull/891

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 19, 2020

👋 Welcome back ehelin! A progress list of the required criteria for merging this PR into pr/890 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Oct 19, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 19, 2020

Webrevs

@openjdk openjdk bot changed the base branch from pr/890 to master Oct 19, 2020
@edvbld
Copy link
Member Author

@edvbld edvbld commented Oct 19, 2020

/help

@openjdk
Copy link

@openjdk openjdk bot commented Oct 19, 2020

@edvbld Available commands:

  • cc - add or remove an additional classification label
  • contributor - adds or removes additional contributors for a PR
  • covered - used when employer has signed the OCA
  • csr - require a compatibility and specification request (CSR) for this pull request
  • help - shows this text
  • integrate - performs integration of the changes in the PR
  • issue - edit the list of issues that this PR solves
  • label - add or remove an additional classification label
  • reviewer - manage additional reviewers for a PR
  • reviewers - set the number of additional required reviewers for this PR
  • signed - used after signing the OCA
  • solves - edit the list of issues that this PR solves
  • sponsor - performs integration of a PR that is authored by a non-committer
  • summary - updates the summary in the commit message
  • test - used to run tests

Copy link
Member

@rwestberg rwestberg left a comment

Looks good!

@openjdk
Copy link

@openjdk openjdk bot commented Oct 20, 2020

@edvbld This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

🔍 One or more changes in this pull request modifies files in areas of the source code that often require two reviewers. Please consider if this is the case for this pull request, and if so, await a second reviewer to approve this pull request before you integrate it.

🌎 Applicable reviewers for one or more changes in this pull request are spread across multiple different time zones. Please consider waiting with integrating this pull request until it has been out for review for at least 24 hours to give all reviewers a chance to review the pull request.

After integration, the commit message for the final commit will be:

forge: add HostedRepository.recentCommitComments

Reviewed-by: rwestberg

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 8f29ac9: Allow a remote pre-integration branch to be missing

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Oct 20, 2020
@edvbld
Copy link
Member Author

@edvbld edvbld commented Oct 21, 2020

/integrate

@openjdk openjdk bot closed this Oct 21, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Oct 21, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Oct 21, 2020

@edvbld Since your change was applied there have been 4 commits pushed to the master branch:

  • 797ac2c: Avoid storing empty files
  • c596e45: Use a separate watchdog thread for the WorkItem scheduler
  • 313e7e1: Give up waiting for the auth lock after a while
  • 8f29ac9: Allow a remote pre-integration branch to be missing

Your commit was automatically rebased without conflicts.

Pushed as commit 63e61c9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants