Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try adapting to malformed mboxes #91

Closed
wants to merge 2 commits into from

Conversation

@rwestberg
Copy link
Member

@rwestberg rwestberg commented Aug 28, 2019

Hi all,

Please review this change that tries to handle malformed mbox files, where lines start with From without being an actual message break. If the lines following the From cannot be parsed as an email, append it to the previous message and try again.

Best regards,
Robin

Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Approvers

  • Erik Helin (ehelin - Reviewer)
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Aug 28, 2019

👋 Welcome back rwestberg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request (refresh this page to view it).

@openjdk openjdk bot added the rfr label Aug 28, 2019
@mlbridge
Copy link

@mlbridge mlbridge bot commented Aug 28, 2019

Webrevs

@edvbld
edvbld approved these changes Aug 28, 2019
Copy link
Member

@edvbld edvbld left a comment

Looks good!

@openjdk openjdk bot removed the rfr label Aug 28, 2019
@openjdk
Copy link

@openjdk openjdk bot commented Aug 28, 2019

@rwestberg This change can now be integrated. The commit message will be:

Try adapting to malformed mboxes

Reviewed-by: ehelin
  • If you would like to add a summary, use the /summary command.
  • To list additional contributors, use the /contributor command.

Since the source branch of this PR was last updated there have been 2 commits pushed to the master branch:

  • c7ffefa: Try adapting to malformed mboxes
  • 03ea4f9: 51: Authentication token generation failure

Your changes cannot be rebased automatically without conflicts, so you will need to merge master into your branch before integrating.

@openjdk openjdk bot added the ready label Aug 28, 2019
@rwestberg
Copy link
Member Author

@rwestberg rwestberg commented Aug 28, 2019

/integrate

1 similar comment
@rwestberg
Copy link
Member Author

@rwestberg rwestberg commented Aug 28, 2019

/integrate

@openjdk openjdk bot closed this Aug 28, 2019
@openjdk openjdk bot added the integrated label Aug 28, 2019
@openjdk
Copy link

@openjdk openjdk bot commented Aug 28, 2019

@rwestberg The following commits have been pushed to master since your change was applied:

Your commit was automatically rebased without conflicts.
Pushed as commit c7ffefa.

@openjdk
Copy link

@openjdk openjdk bot commented Aug 28, 2019

@rwestberg The following commits have been pushed to master since your change was applied:

Your commit was automatically rebased without conflicts.
Warning! Your commit did not result in any changes! No push attempt will be made.

@openjdk openjdk bot added the outdated label Aug 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants