Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

51: Authentication token generation failure #92

Closed
wants to merge 1 commit into from

Conversation

@rwestberg
Copy link
Member

rwestberg commented Aug 28, 2019

Hi all,

Please review this minor change that adjusts the expiration time of GitHub authentication tokens to be slightly below the maximum allowed value.

Best regards,
Robin

Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Approvers

  • Erik Helin (ehelin - Reviewer)
@bridgekeeper
Copy link

bridgekeeper bot commented Aug 28, 2019

👋 Welcome back rwestberg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request (refresh this page to view it).

@openjdk openjdk bot added the rfr label Aug 28, 2019
@mlbridge
Copy link

mlbridge bot commented Aug 28, 2019

Webrevs

@edvbld
edvbld approved these changes Aug 28, 2019
Copy link
Member

edvbld left a comment

Looks good, thanks for fixing this!

@openjdk openjdk bot removed the rfr label Aug 28, 2019
@openjdk
Copy link

openjdk bot commented Aug 28, 2019

@rwestberg This change can now be integrated. The commit message will be:

51: Authentication token generation failure

Reviewed-by: ehelin
  • If you would like to add a summary, use the /summary command.
  • To list additional contributors, use the /contributor command.
  • To integrate this PR with the above commit message, type /integrate in a new comment.
@openjdk openjdk bot added the ready label Aug 28, 2019
@rwestberg
Copy link
Member Author

rwestberg commented Aug 28, 2019

/integrate

@openjdk openjdk bot closed this Aug 28, 2019
@openjdk
Copy link

openjdk bot commented Aug 28, 2019

@rwestberg Pushed as commit 03ea4f9.

@openjdk openjdk bot added the integrated label Aug 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.