Add tabfiles to jcheck configuration

[magicus]

The tabfiles setting is just like the files setting, but it lists files in which tabs are allowed.

(This is to support makefiles)

---

Progress

• Change must not contain extraneous whitespace
• Change must be properly reviewed

Reviewers

• Erik Joelsson (@erikj79 - Reviewer) ⚠️ Review applies to 4aaa659
• Erik Helin (@edvbld - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/skara pull/929/head:pull/929
$ git checkout pull/929

[bridgekeeper]

👋 Welcome back ihse! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[mlbridge]

Webrevs

• 03: Full - Incremental (0a19699)
• 02: Full - Incremental (4aaa659)
• 01: Full - Incremental (d8c4f75)
• 00: Full (b4ffcde)

[edvbld]

How about naming the configuration ignore-tabs instead? To make it a bit more clear what it does :)

[magicus]

@edvbld

How about naming the configuration ignore-tabs instead? To make it a bit more clear what it does :)

Sure. I checked for "prior art" on multiword keywords, but did not find any such instances. :) This will mean that the corresponding Java variable needs a different name, since "-" is not valid in Java identifiers.

(And if we're going this way, personally I think allow-tabs would be even better)

[openjdk]

@magicus This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

🔍 One or more changes in this pull request modifies files in areas of the source code that often require two reviewers. Please consider if this is the case for this pull request, and if so, await a second reviewer to approve this pull request before you integrate it.

After integration, the commit message for the final commit will be:

Add tabfiles to jcheck configuration

Reviewed-by: erikj, ehelin

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 22 new commits pushed to the master branch:

• f4dc83b: 725: Rename git-pr-reviewer --add to git-pr-reviewer --credit
• 38aa5bf: Only consider resolved backports when applying sync label
• 0a8b1e7: vcs: add DiffComparator for comparing diffs
• 2e35aff: pr: return HostedCommit from CheckRun.backportedFrom
• 4f35b6f: cli: add command git-backport
• 4afd995: Restrict merge PR commit titles if required by the jcheck configuration
• c73f2b0: Run skara pre-submit tests against the latest commit on the target branch
• dd7933b: forge: return commit comment from addCommitComment
• 9a725bb: pr: add /backport commit command
• 4d7471a: 768: Skara bot should prevent attempt to use JBS backport issue ID in PR
• ... and 12 more: https://git.openjdk.java.net/skara/compare/e583ed5af5f83acef8f922f23d38eb7be6a9940b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@erikj79, @edvbld) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[rwestberg]

Looks good in general, but would be nice with a test to see that it still flags trailing tabs (which I think it is meant to do still, right?)

[magicus]

@rwestberg @edvbld I have now added a test that verifies that trailing tabs are always rejected, and that leading tabs are accepted iff ignore-tabs is true for that file.

Ok to integrate now?

[edvbld]

Looks good!

[magicus]

/integrate

[openjdk]

@magicus
Your change (at version 0a19699) is now ready to be sponsored by a Committer.

[rwestberg]

/sponsor

[openjdk]

@rwestberg @magicus Since your change was applied there have been 22 commits pushed to the master branch:

• f4dc83b: 725: Rename git-pr-reviewer --add to git-pr-reviewer --credit
• 38aa5bf: Only consider resolved backports when applying sync label
• 0a8b1e7: vcs: add DiffComparator for comparing diffs
• 2e35aff: pr: return HostedCommit from CheckRun.backportedFrom
• 4f35b6f: cli: add command git-backport
• 4afd995: Restrict merge PR commit titles if required by the jcheck configuration
• c73f2b0: Run skara pre-submit tests against the latest commit on the target branch
• dd7933b: forge: return commit comment from addCommitComment
• 9a725bb: pr: add /backport commit command
• 4d7471a: 768: Skara bot should prevent attempt to use JBS backport issue ID in PR
• ... and 12 more: https://git.openjdk.java.net/skara/compare/e583ed5af5f83acef8f922f23d38eb7be6a9940b...master

Your commit was automatically rebased without conflicts.

Pushed as commit d468590.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.