Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace explicit type with <> #935

Closed
wants to merge 1 commit into from
Closed

Replace explicit type with <> #935

wants to merge 1 commit into from

Conversation

amCap1712
Copy link
Contributor

@amCap1712 amCap1712 commented Nov 1, 2020

Hi!
Analyzing the skara codebase in Intellij IDEA reveals that there several opportunities for minor improvements in the codebase. One such improvement is to use the <> instead of explicit types. Hence, I propose this patch.

There are other inspections and improvements possible as well. In case such changes are welcome, I would be happy to contribute patches for those as well. Also, in that case should those changes be a part of this PR or should there be a separate PR for each ?
Thanks.
Regards,
Kartik


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Reviewers

Download

$ git fetch https://git.openjdk.java.net/skara pull/935/head:pull/935
$ git checkout pull/935

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Nov 1, 2020

👋 Welcome back amCap1712! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Nov 1, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Nov 1, 2020

Webrevs

edvbld
edvbld approved these changes Nov 2, 2020
Copy link
Member

@edvbld edvbld left a comment

Looks good!

@openjdk
Copy link

@openjdk openjdk bot commented Nov 2, 2020

@amCap1712 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

🔍 One or more changes in this pull request modifies files in areas of the source code that often require two reviewers. Please consider if this is the case for this pull request, and if so, await a second reviewer to approve this pull request before you integrate it.

🌎 Applicable reviewers for one or more changes in this pull request are spread across multiple different time zones. Please consider waiting with integrating this pull request until it has been out for review for at least 24 hours to give all reviewers a chance to review the pull request.

After integration, the commit message for the final commit will be:

Replace explicit type with <>

Reviewed-by: ehelin

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 13 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@edvbld) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Nov 2, 2020
@amCap1712 amCap1712 changed the title Miscellaneous minor code improvements Replace explicit type with <> Nov 2, 2020
@amCap1712
Copy link
Contributor Author

@amCap1712 amCap1712 commented Nov 2, 2020

/integrate

@openjdk openjdk bot added the sponsor label Nov 2, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Nov 2, 2020

@amCap1712
Your change (at version 4af2fe2) is now ready to be sponsored by a Committer.

@edvbld
Copy link
Member

@edvbld edvbld commented Nov 2, 2020

/sponsor

@openjdk openjdk bot closed this Nov 2, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Nov 2, 2020

@edvbld @amCap1712 Since your change was applied there have been 13 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

Pushed as commit 7eaebc7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

openjdk-notifier bot referenced this issue Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants