Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SKARA-725: Rename git-pr-reviewer --add to git-pr-reviewer --credit #938

Closed
wants to merge 2 commits into from
Closed

SKARA-725: Rename git-pr-reviewer --add to git-pr-reviewer --credit #938

wants to merge 2 commits into from

Conversation

amCap1712
Copy link
Contributor

@amCap1712 amCap1712 commented Nov 2, 2020

Hi!
The patch renames the add option to the credit in accordance with the change in the /reviewer command on OpenJDK Github bot.

I was unable to find any related documentation that should reflect this change. If something needs to be updated, kindly point me to it and I'll do the needful changes.

Thanks.
Regards,
Kartik


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Issue

  • SKARA-725: Rename git-pr-reviewer --add to git-pr-reviewer --credit

Reviewers

Download

$ git fetch https://git.openjdk.java.net/skara pull/938/head:pull/938
$ git checkout pull/938

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Nov 2, 2020

👋 Welcome back amCap1712! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Nov 2, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Nov 2, 2020

Webrevs

@mlbridge
Copy link

@mlbridge mlbridge bot commented Nov 3, 2020

Mailing list message from David Holmes on skara-dev:

Hi,

On 3/11/2020 3:27 am, Kartik Ohri wrote:

Hi!
The patch renames the add option to the credit in accordance with the change in the `/reviewer` command on OpenJDK Github bot.

I was unable to find any related documentation that should reflect this change. If something needs to be updated, kindly point me to it and I'll do the needful changes.

Documentation is here:

https://wiki.openjdk.java.net/display/SKARA/Pull+Request+Commands#PullRequestCommands-/reviewer

Cheers,
David

@amCap1712
Copy link
Contributor Author

@amCap1712 amCap1712 commented Nov 3, 2020

Thanks David for the reply. I think the link you mentioned is rather for the PR bot not the cli tool. But in any case, I do not have a OpenJDK login so I think cannot modify that page.

edvbld
edvbld approved these changes Nov 12, 2020
Copy link
Member

@edvbld edvbld left a comment

Looks good, just a small suggestion on the helptext for the option. I updated the documentation at https://wiki.openjdk.java.net/display/SKARA/reviewer.

@openjdk
Copy link

@openjdk openjdk bot commented Nov 12, 2020

@amCap1712 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

🔍 One or more changes in this pull request modifies files in areas of the source code that often require two reviewers. Please consider if this is the case for this pull request, and if so, await a second reviewer to approve this pull request before you integrate it.

After integration, the commit message for the final commit will be:

725: Rename git-pr-reviewer --add to git-pr-reviewer --credit

Reviewed-by: ehelin

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 14 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@edvbld) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Nov 12, 2020
Co-authored-by: Erik Duveblad <erik.helin@oracle.com>
@amCap1712
Copy link
Contributor Author

@amCap1712 amCap1712 commented Nov 12, 2020

/integrate

@openjdk openjdk bot added the sponsor label Nov 12, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Nov 12, 2020

@amCap1712
Your change (at version f9b5ce9) is now ready to be sponsored by a Committer.

@edvbld
Copy link
Member

@edvbld edvbld commented Nov 12, 2020

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Nov 12, 2020

@edvbld @amCap1712 Since your change was applied there have been 14 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

Pushed as commit f4dc83b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants