Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pr: relaxed matching of backport PR titles #955

wants to merge 1 commit into from


Copy link

@edvbld edvbld commented Nov 17, 2020

Hi all,

please review this patch that makes the matching for "backport" style pull requests a bit more relaxed with regards to whitespace.


  • Added three new unit tests



  • Change must not contain extraneous whitespace
  • Change must be properly reviewed


Linux x64 Windows x64 macOS x64
Build / test ✔️ (1/1 passed) ✔️ (1/1 passed) ✔️ (1/1 passed)



$ git fetch pull/955/head:pull/955
$ git checkout pull/955

Copy link

@bridgekeeper bridgekeeper bot commented Nov 17, 2020

👋 Welcome back ehelin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Nov 17, 2020
Copy link

@mlbridge mlbridge bot commented Nov 17, 2020


Copy link

@rwestberg rwestberg left a comment

Looks good!

Copy link

@openjdk openjdk bot commented Nov 18, 2020

@edvbld This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file for details.

🔍 One or more changes in this pull request modifies files in areas of the source code that often require two reviewers. Please consider if this is the case for this pull request, and if so, await a second reviewer to approve this pull request before you integrate it.

🌎 Applicable reviewers for one or more changes in this pull request are spread across multiple different time zones. Please consider waiting with integrating this pull request until it has been out for review for at least 24 hours to give all reviewers a chance to review the pull request.

After integration, the commit message for the final commit will be:

pr: relaxed matching of backport PR titles

Reviewed-by: rwestberg

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 8295855: git-pr: update git-pr -h

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Nov 18, 2020
Copy link
Member Author

@edvbld edvbld commented Nov 18, 2020


@openjdk openjdk bot closed this Nov 18, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Nov 18, 2020
Copy link

@openjdk openjdk bot commented Nov 18, 2020

@edvbld Since your change was applied there has been 1 commit pushed to the master branch:

  • 8295855: git-pr: update git-pr -h

Your commit was automatically rebased without conflicts.

Pushed as commit 1eb72e2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

openjdk-notifier bot referenced this issue Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants