Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter out invalid GitLab merge requests #956

Closed
wants to merge 3 commits into from

Conversation

rwestberg
Copy link
Member

@rwestberg rwestberg commented Nov 18, 2020

Sometimes GitLab returns merge request data that doesn't contain a head hash. Since we can't really do anything with these, just ignore them.


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Testing

Linux x64 Windows x64 macOS x64
Build / test ✔️ (1/1 passed) ✔️ (1/1 passed) (1/1 running)

Reviewers

Download

$ git fetch https://git.openjdk.java.net/skara pull/956/head:pull/956
$ git checkout pull/956

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Nov 18, 2020

👋 Welcome back rwestberg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Nov 18, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Nov 18, 2020

Webrevs

edvbld
edvbld approved these changes Nov 18, 2020
Copy link
Member

@edvbld edvbld left a comment

Looks good, just a minor suggestion on how to make mergeRequestValid a bit shorter 😸

@openjdk
Copy link

@openjdk openjdk bot commented Nov 18, 2020

@rwestberg This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

🔍 One or more changes in this pull request modifies files in areas of the source code that often require two reviewers. Please consider if this is the case for this pull request, and if so, await a second reviewer to approve this pull request before you integrate it.

🌎 Applicable reviewers for one or more changes in this pull request are spread across multiple different time zones. Please consider waiting with integrating this pull request until it has been out for review for at least 24 hours to give all reviewers a chance to review the pull request.

After integration, the commit message for the final commit will be:

Filter out invalid GitLab merge requests

Reviewed-by: ehelin

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Nov 18, 2020
Robin Westberg and others added 2 commits Nov 18, 2020
Co-authored-by: Erik Duveblad <erik.helin@oracle.com>
@rwestberg
Copy link
Member Author

@rwestberg rwestberg commented Nov 18, 2020

/integrate

@openjdk openjdk bot closed this Nov 18, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Nov 18, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Nov 18, 2020

@rwestberg Since your change was applied there has been 1 commit pushed to the master branch:

  • 1eb72e2: pr: relaxed matching of backport PR titles

Your commit was automatically rebased without conflicts.

Pushed as commit bccf292.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants