New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filter out invalid GitLab merge requests #956
Conversation
|
Webrevs
|
Looks good, just a minor suggestion on how to make mergeRequestValid
a bit shorter
forge/src/main/java/org/openjdk/skara/forge/gitlab/GitLabRepository.java
Outdated
Show resolved
Hide resolved
forge/src/main/java/org/openjdk/skara/forge/gitlab/GitLabRepository.java
Outdated
Show resolved
Hide resolved
forge/src/main/java/org/openjdk/skara/forge/gitlab/GitLabRepository.java
Outdated
Show resolved
Hide resolved
@rwestberg This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the
|
Co-authored-by: Erik Duveblad <erik.helin@oracle.com>
/integrate |
@rwestberg Since your change was applied there has been 1 commit pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit bccf292. |
Sometimes GitLab returns merge request data that doesn't contain a head hash. Since we can't really do anything with these, just ignore them.
Progress
Testing
Reviewers
Download
$ git fetch https://git.openjdk.java.net/skara pull/956/head:pull/956
$ git checkout pull/956