Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ReadOnlyRepository::contains #96

Closed
wants to merge 1 commit into from
Closed

Conversation

edvbld
Copy link
Member

@edvbld edvbld commented Aug 28, 2019

Hi all,

this patch adds ReadOnlyRepository::contains that checks if a given hash h resides in the given branch b. I also added small unit test case, it was hard to add more elaborate tests given that HgRepository::branch creates a bookmark and not a branch.

Testing

  • sh gradlew test passes
  • Added a small unit test

Thanks,
Erik

Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Approvers

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Aug 28, 2019

👋 Welcome back ehelin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request (refresh this page to view it).

@openjdk openjdk bot added the rfr label Aug 28, 2019
@mlbridge
Copy link

@mlbridge mlbridge bot commented Aug 28, 2019

Webrevs

Copy link
Member

@rwestberg rwestberg left a comment

Looks good!

@openjdk openjdk bot removed the rfr label Aug 29, 2019
@openjdk
Copy link

@openjdk openjdk bot commented Aug 29, 2019

@edvbld This change can now be integrated. The commit message will be:

Add ReadOnlyRepository::contains

Reviewed-by: rwestberg
  • If you would like to add a summary, use the /summary command.
  • To list additional contributors, use the /contributor command.

Since the source branch of this PR was last updated there have been 10 commits pushed to the master branch:

  • 4fb0315: Add newline at end of file to MergeTests.java
  • 7a927a0: Add default safe methods for Repository::checkout
  • bcd21d8: TestPullRequest::getBody always returns empty string
  • 984bb12: 53: Decouple review requirement from the jcheck status
  • c7ffefa: Try adapting to malformed mboxes
  • 03ea4f9: 51: Authentication token generation failure
  • b9277c9: Filter out huge files to avoid excessive storage use
  • 31549d0: Allow the notify bot to watch multiple branches
  • 9ca8782: Parse .ssh/config in git-pr if needed
  • f3a450e: Split large webrev pushes

Since there are no conflicts, your changes will automatically be rebased on top of the above commits when integrating. If you prefer to do this manually, please merge master into your branch first.

  • To integrate this PR with the above commit message, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Aug 29, 2019
@edvbld
Copy link
Member Author

@edvbld edvbld commented Aug 29, 2019

/integrate

@edvbld
Copy link
Member Author

@edvbld edvbld commented Aug 29, 2019

@openjdk-bot now please

@openjdk openjdk bot closed this Aug 29, 2019
@openjdk openjdk bot added the integrated label Aug 29, 2019
@openjdk
Copy link

@openjdk openjdk bot commented Aug 29, 2019

@edvbld The following commits have been pushed to master since your change was applied:

Your commit was automatically rebased without conflicts.
Pushed as commit 25a8f8f.

@edvbld
Copy link
Member Author

@edvbld edvbld commented Aug 29, 2019

/integrate

@edvbld edvbld deleted the upstream/2 branch Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants