Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move testing information from the PR body to checks #962

Closed
wants to merge 3 commits into from

Conversation

rwestberg
Copy link
Member

@rwestberg rwestberg commented Nov 25, 2020

When summarizing pre-submit test results for a PR, show the results as a number of checks instead of a table in the PR body. This makes them more similar to the source information, and avoids excessive PR body updates.


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Reviewers

Download

$ git fetch https://git.openjdk.java.net/skara pull/962/head:pull/962
$ git checkout pull/962

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Nov 25, 2020

👋 Welcome back rwestberg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Nov 25, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Nov 25, 2020

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented Nov 27, 2020

@rwestberg This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

🔍 One or more changes in this pull request modifies files in areas of the source code that often require two reviewers. Please consider if this is the case for this pull request, and if so, await a second reviewer to approve this pull request before you integrate it.

After integration, the commit message for the final commit will be:

Move testing information from the PR body to checks

Reviewed-by: jvernee

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • a99a226: Add newline after closed issue warning

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Nov 27, 2020
…stInfoBot.java

Co-authored-by: Jorn Vernee <JornVernee@users.noreply.github.com>
@rwestberg
Copy link
Member Author

@rwestberg rwestberg commented Dec 1, 2020

/integrate

@openjdk openjdk bot closed this Dec 1, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Dec 1, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Dec 1, 2020

@rwestberg Since your change was applied there has been 1 commit pushed to the master branch:

  • a99a226: Add newline after closed issue warning

Your commit was automatically rebased without conflicts.

Pushed as commit cd1a285.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@tstuefe
Copy link
Member

@tstuefe tstuefe commented Dec 2, 2020

Hi,

I don't see the results now at all. See e.g. openjdk/jdk#1390 .

Am I doing something wrong?

Thanks, Thomas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants