Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add newline after closed issue warning #963

Closed
wants to merge 2 commits into from

Conversation

JornVernee
Copy link
Member

@JornVernee JornVernee commented Nov 26, 2020

Adds a missing newline after the 'issue is not open' warning, which is currently missing, and leads to the list not being formatted correctly. See e.g. openjdk/jdk#1444

image

Any testing needed for this?


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Reviewers

Download

$ git fetch https://git.openjdk.java.net/skara pull/963/head:pull/963
$ git checkout pull/963

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 26, 2020

👋 Welcome back jvernee! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Nov 26, 2020
@mlbridge
Copy link

mlbridge bot commented Nov 26, 2020

Webrevs

Copy link
Member

@rwestberg rwestberg left a comment

Looks good, I guess a test would be nice, but since there isn't one at the moment there's no need to remedy that right now unless you really want to.

@openjdk
Copy link

openjdk bot commented Nov 27, 2020

@JornVernee This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

🔍 One or more changes in this pull request modifies files in areas of the source code that often require two reviewers. Please consider if this is the case for this pull request, and if so, await a second reviewer to approve this pull request before you integrate it.

🌎 Applicable reviewers for one or more changes in this pull request are spread across multiple different time zones. Please consider waiting with integrating this pull request until it has been out for review for at least 24 hours to give all reviewers a chance to review the pull request.

After integration, the commit message for the final commit will be:

Add newline after closed issue warning

Reviewed-by: rwestberg

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Nov 27, 2020
@JornVernee
Copy link
Member Author

JornVernee commented Nov 27, 2020

/integrate

@openjdk openjdk bot closed this Nov 27, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Nov 27, 2020
@openjdk
Copy link

openjdk bot commented Nov 27, 2020

@JornVernee Pushed as commit a99a226.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

openjdk-notifier bot referenced this issue Nov 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants