New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"java.se" matches "java.security.jgss" as well #980
Conversation
core-libs does not need to care about these security-related modules.
|
Webrevs
|
/integrate |
@wangweij This PR has not yet been marked as ready for integration. |
/integrate |
@wangweij This PR has not yet been marked as ready for integration. |
Hi @rwestberg, can you please sponsor this change? Thanks. |
It seems like there are more directories that do not end in slash. I think it would be prudent to update them as well. |
Looks good, I guess you can decide if you want to take on Magnus' comment in this PR or leave that for a future improvement.
@wangweij This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@rwestberg) but any other Committer may sponsor as well.
|
@magicus @rwestberg Thanks for the comment. I made some other changes but haven't touched |
/integrate |
/sponsor |
@rwestberg @wangweij Pushed as commit 8b16dad. |
core-libs does not need to care about these security-related modules.
Progress
Reviewers
Download
$ git fetch https://git.openjdk.java.net/skara pull/980/head:pull/980
$ git checkout pull/980