Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"java.se" matches "java.security.jgss" as well #980

Closed
wants to merge 2 commits into from

Conversation

wangweij
Copy link
Contributor

@wangweij wangweij commented Dec 22, 2020

core-libs does not need to care about these security-related modules.


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Reviewers

Download

$ git fetch https://git.openjdk.java.net/skara pull/980/head:pull/980
$ git checkout pull/980

core-libs does not need to care about these security-related modules.
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Dec 22, 2020

👋 Welcome back weijun! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Dec 22, 2020

Webrevs

@wangweij
Copy link
Contributor Author

@wangweij wangweij commented Dec 22, 2020

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Dec 22, 2020

@wangweij This PR has not yet been marked as ready for integration.

@wangweij
Copy link
Contributor Author

@wangweij wangweij commented Dec 31, 2020

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Dec 31, 2020

@wangweij This PR has not yet been marked as ready for integration.

@wangweij
Copy link
Contributor Author

@wangweij wangweij commented Jan 4, 2021

Hi @rwestberg, can you please sponsor this change? Thanks.

@magicus
Copy link
Member

@magicus magicus commented Jan 11, 2021

It seems like there are more directories that do not end in slash. I think it would be prudent to update them as well.

Copy link
Member

@rwestberg rwestberg left a comment

Looks good, I guess you can decide if you want to take on Magnus' comment in this PR or leave that for a future improvement.

@openjdk
Copy link

@openjdk openjdk bot commented Jan 11, 2021

@wangweij This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

🔍 One or more changes in this pull request modifies files in areas of the source code that often require two reviewers. Please consider if this is the case for this pull request, and if so, await a second reviewer to approve this pull request before you integrate it.

After integration, the commit message for the final commit will be:

"java.se" matches "java.security.jgss" as well

Reviewed-by: xuelei, rwestberg, ihse

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@rwestberg) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Jan 11, 2021
@wangweij
Copy link
Contributor Author

@wangweij wangweij commented Jan 11, 2021

@magicus @rwestberg Thanks for the comment. I made some other changes but haven't touched java.sql that matches both java.sql and java.sql.rowset which could be intentional.

@wangweij
Copy link
Contributor Author

@wangweij wangweij commented Jan 11, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Jan 11, 2021

@wangweij
Your change (at version e1ae8a7) is now ready to be sponsored by a Committer.

@openjdk openjdk bot added the sponsor label Jan 11, 2021
@rwestberg
Copy link
Member

@rwestberg rwestberg commented Jan 12, 2021

/sponsor

@openjdk openjdk bot closed this Jan 12, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jan 12, 2021

@rwestberg @wangweij Pushed as commit 8b16dad.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@openjdk openjdk bot removed the rfr label Jan 12, 2021
@wangweij wangweij deleted the patch-2 branch Apr 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants