Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Update to JDK 15.0.2 #989

Closed
wants to merge 1 commit into from
Closed

Build: Update to JDK 15.0.2 #989

wants to merge 1 commit into from

Conversation

oscerd
Copy link
Contributor

@oscerd oscerd commented Jan 20, 2021

Hello all,

Just a little PR for upgrading to JDK 15.0.2.

make images passed fine and make test too.

Thank you


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Reviewers

Download

$ git fetch https://git.openjdk.java.net/skara pull/989/head:pull/989
$ git checkout pull/989

@bridgekeeper bridgekeeper bot added the oca label Jan 20, 2021
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jan 20, 2021

Hi @oscerd, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user oscerd" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

@oscerd oscerd closed this Jan 20, 2021
@oscerd oscerd reopened this Jan 20, 2021
@oscerd
Copy link
Contributor Author

@oscerd oscerd commented Jan 20, 2021

I believe I'm covered under the blanket Red Hat agreement

@oscerd
Copy link
Contributor Author

@oscerd oscerd commented Jan 20, 2021

/covered

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jan 20, 2021

Thank you! Please allow for a few business days to verify that your employer has signed the OCA. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

@oscerd
Copy link
Contributor Author

@oscerd oscerd commented Jan 28, 2021

Am I supposed to do something now?

@gunnarmorling
Copy link

@gunnarmorling gunnarmorling commented Jan 29, 2021

Hey @robilad, could you kick off the OCA verification for fellow Red Hatter @oscerd?

@oscerd
Copy link
Contributor Author

@oscerd oscerd commented Jan 29, 2021

Thanks @gunnarmorling :-)

@mlbridge
Copy link

@mlbridge mlbridge bot commented Feb 1, 2021

Webrevs

@robilad
Copy link

@robilad robilad commented Feb 1, 2021

Thanks, I have marked the account as verified.

@edvbld
Copy link
Member

@edvbld edvbld commented Feb 2, 2021

Thanks for contributing @oscerd! Would you mind enabling GitHub Actions in your fork so that the CI tests can be run?

Thanks!
Erik

@oscerd
Copy link
Contributor Author

@oscerd oscerd commented Feb 2, 2021

@edvbld Done

@oscerd
Copy link
Contributor Author

@oscerd oscerd commented Feb 2, 2021

I don't know if there is something else to do on my side.

@oscerd oscerd closed this Feb 3, 2021
@oscerd oscerd reopened this Feb 3, 2021
@edvbld
Copy link
Member

@edvbld edvbld commented Feb 3, 2021

@oscerd you can just merge the master branch into your branch jdk-15.0.2 (the merge commit will be automatically squashed when we integrate your changes, so don't worry). Then push the merge commit, then the GitHub Actions will be triggered 👍

@oscerd
Copy link
Contributor Author

@oscerd oscerd commented Feb 3, 2021

Done

@oscerd
Copy link
Contributor Author

@oscerd oscerd commented Feb 3, 2021

Thanks for helpin on the workflow. All seems to be ok.

edvbld
edvbld approved these changes Feb 4, 2021
Copy link
Member

@edvbld edvbld left a comment

Looks good! 🎉

@openjdk
Copy link

@openjdk openjdk bot commented Feb 4, 2021

@oscerd This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

🔍 One or more changes in this pull request modifies files in areas of the source code that often require two reviewers. Please consider if this is the case for this pull request, and if so, await a second reviewer to approve this pull request before you integrate it.

After integration, the commit message for the final commit will be:

Build: Update to JDK 15.0.2

Reviewed-by: ehelin

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • ae50218: 868: Skara should ignore .gitconfig and /etc/gitconfig
  • b0be0fa: 880: Map jdk.jpackage to core-libs-dev
  • 2d5199c: checkout: use to repo name as path to marks

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@edvbld) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Feb 4, 2021
@oscerd
Copy link
Contributor Author

@oscerd oscerd commented Feb 4, 2021

Thanks for reviewing, we now need a second reviewer right?

@edvbld
Copy link
Member

@edvbld edvbld commented Feb 4, 2021

Thanks for reviewing, we now need a second reviewer right?

No, Skara only requires one Reviewer (otherwise the bot wouldn't have labelled this as "ready'). You are good to go, just follow the bot's instructions 🤖

@oscerd
Copy link
Contributor Author

@oscerd oscerd commented Feb 4, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Feb 4, 2021

@oscerd
Your change (at version 2a28e26) is now ready to be sponsored by a Committer.

@openjdk openjdk bot added the sponsor label Feb 4, 2021
@edvbld
Copy link
Member

@edvbld edvbld commented Feb 5, 2021

/sponsor

@openjdk openjdk bot closed this Feb 5, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Feb 5, 2021

@edvbld @oscerd Since your change was applied there have been 3 commits pushed to the master branch:

  • ae50218: 868: Skara should ignore .gitconfig and /etc/gitconfig
  • b0be0fa: 880: Map jdk.jpackage to core-libs-dev
  • 2d5199c: checkout: use to repo name as path to marks

Your commit was automatically rebased without conflicts.

Pushed as commit e668227.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants