Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

880: Map jdk.jpackage to core-libs-dev #996

Closed

Conversation

kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Jan 29, 2021

The jpackage tool moved from the jdk.incubator.jpackage module to jdk.jpackage in JDK 16. The jdk.json config file needs to be updated accordingly so that jpackage reviews are sent to core-libs-dev.


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Issue

  • SKARA-880: Map jdk.jpackage to core-libs-dev

Reviewers

Download

$ git fetch https://git.openjdk.java.net/skara pull/996/head:pull/996
$ git checkout pull/996

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jan 29, 2021

👋 Welcome back kcr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Jan 29, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jan 29, 2021

Webrevs

Copy link
Member

@rwestberg rwestberg left a comment

Looks good!

@openjdk
Copy link

@openjdk openjdk bot commented Feb 3, 2021

@kevinrushforth This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

🔍 One or more changes in this pull request modifies files in areas of the source code that often require two reviewers. Please consider if this is the case for this pull request, and if so, await a second reviewer to approve this pull request before you integrate it.

After integration, the commit message for the final commit will be:

880: Map jdk.jpackage to core-libs-dev

Reviewed-by: rwestberg

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • 3c18e06: Update the readme to include IntelliJ setup instructions
  • a0b7057: checkout: fetch origin before checking out branch
  • 0b6b051: build: add convenience target for bots

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@rwestberg) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Feb 3, 2021
@kevinrushforth
Copy link
Member Author

@kevinrushforth kevinrushforth commented Feb 3, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Feb 3, 2021

@kevinrushforth
Your change (at version 1dd7bae) is now ready to be sponsored by a Committer.

@openjdk openjdk bot added the sponsor label Feb 3, 2021
@edvbld
Copy link
Member

@edvbld edvbld commented Feb 4, 2021

/sponsor

@openjdk openjdk bot closed this Feb 4, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Feb 4, 2021

@edvbld @kevinrushforth Since your change was applied there have been 4 commits pushed to the master branch:

  • 2d5199c: checkout: use to repo name as path to marks
  • 3c18e06: Update the readme to include IntelliJ setup instructions
  • a0b7057: checkout: fetch origin before checking out branch
  • 0b6b051: build: add convenience target for bots

Your commit was automatically rebased without conflicts.

Pushed as commit b0be0fa.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@kevinrushforth kevinrushforth deleted the 880-jdk.jpackage branch Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants