New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
880: Map jdk.jpackage to core-libs-dev #996
Conversation
👋 Welcome back kcr! A progress list of the required criteria for merging this PR into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
@kevinrushforth This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. 🔍 One or more changes in this pull request modifies files in areas of the source code that often require two reviewers. Please consider if this is the case for this pull request, and if so, await a second reviewer to approve this pull request before you integrate it. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 3 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@rwestberg) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
/integrate |
@kevinrushforth |
/sponsor |
@edvbld @kevinrushforth Since your change was applied there have been 4 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit b0be0fa. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
The
jpackage
tool moved from thejdk.incubator.jpackage
module tojdk.jpackage
in JDK 16. Thejdk.json
config file needs to be updated accordingly so thatjpackage
reviews are sent tocore-libs-dev
.Progress
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/skara pull/996/head:pull/996
$ git checkout pull/996