8370634: [lworld] super should not be allowed in compact constructors

Reviewed-by: liach

Author: Vicente Romero

src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Attr.java

@@ -1108,7 +1108,8 @@ public void visitMethodDef(JCMethodDecl tree) {
                                 );
                             }
 
-                            if (!allowValueClasses && TreeInfo.hasAnyConstructorCall(tree)) {
+                            if ((!allowValueClasses || TreeInfo.isCompactConstructor(tree)) &&
+                                    TreeInfo.hasAnyConstructorCall(tree)) {
                                 log.error(tree, Errors.InvalidCanonicalConstructorInRecord(
                                         Fragments.Canonical, env.enclClass.sym.name,
                                         Fragments.CanonicalMustNotContainExplicitConstructorInvocation));

test/langtools/tools/javac/valhalla/value-objects/ValueObjectCompilationTests.java

@@ -1150,6 +1150,40 @@ static class Foo {
                 """,
                 "new,dup,invokespecial,astore_1,aload_1,invokevirtual,pop,aload_0,aload_1,putfield,aload_0,invokespecial,return"
         );
+
+        assertFail("compiler.err.invalid.canonical.constructor.in.record",
+                """
+                record R(int x) {
+                    public R {
+                        super();
+                    }
+                }
+                """
+        );
+
+        assertFail("compiler.err.invalid.canonical.constructor.in.record",
+                """
+                record R(int x) {
+                    public R {
+                        this();
+                    }
+                    public R() {
+                        this(1);
+                    }
+                }
+                """
+        );
+
+        assertOK(
+                """
+                record R(int x) {
+                    public R(int x) {
+                        this.x = x;
+                        super();
+                    }
+                }
+                """
+        );
     }
 
     void checkMnemonicsFor(String source, String expectedMnemonics) throws Exception {