Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8325952: [lworld] tests refactoring, clean-up #1007

Conversation

vicente-romero-oracle
Copy link
Contributor

@vicente-romero-oracle vicente-romero-oracle commented Feb 15, 2024

test refactoring, removing a bunch of primitive classes tests. Minor bug fix related to interaction of value with other modifiers


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8325952: [lworld] tests refactoring, clean-up (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/1007/head:pull/1007
$ git checkout pull/1007

Update a local copy of the PR:
$ git checkout pull/1007
$ git pull https://git.openjdk.org/valhalla.git pull/1007/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1007

View PR using the GUI difftool:
$ git pr show -t 1007

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/1007.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 15, 2024

👋 Welcome back vromero! A progress list of the required criteria for merging this PR into jep_401_javac will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Feb 15, 2024

@vicente-romero-oracle This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8325952: [lworld] tests refactoring, clean-up

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the jep_401_javac branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the jep_401_javac branch, type /integrate in a new comment.

@mlbridge
Copy link

mlbridge bot commented Feb 15, 2024

Webrevs

@vicente-romero-oracle
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Feb 15, 2024

Going to push as commit 916c8e3.

@openjdk openjdk bot added the integrated label Feb 15, 2024
@openjdk openjdk bot closed this Feb 15, 2024
@openjdk
Copy link

openjdk bot commented Feb 15, 2024

@vicente-romero-oracle Pushed as commit 916c8e3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@vicente-romero-oracle vicente-romero-oracle deleted the JDK-8325952 branch February 15, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant