Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8248251 don't all java.lang.IdentityObject to be redefined or retrans… #101

Closed
wants to merge 1 commit into from

Conversation

hseigel
Copy link
Member

@hseigel hseigel commented Jun 25, 2020

Add check to prevent interface java.lang.IdentityObject from being redefined or retransformed. And, add test case.


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8248251: test IsModifiableClassAgent.java fails trying to retransform java.lang.IdentityObject ⚠️ Title mismatch between PR and JBS.

Reviewers

  • Frederic Parain (fparain - Committer)

Download

$ git fetch https://git.openjdk.java.net/valhalla pull/101/head:pull/101
$ git checkout pull/101

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 25, 2020

👋 Welcome back hseigel! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request.

@openjdk
Copy link

openjdk bot commented Jun 25, 2020

@hseigel This change now passes all automated pre-integration checks, type /integrate in a new comment to proceed. After integration, the commit message will be:

8248251: don't all java.lang.IdentityObject to be redefined or retrans…

Reviewed-by: fparain
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

There are currently no new commits on the lworld branch since the last update of the source branch of this PR. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you would like to avoid potential automatic rebasing, specify the current head hash when integrating, like this: /integrate d39d420797a46671f723e645e357f83dbdf5aeb8.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

@mlbridge
Copy link

mlbridge bot commented Jun 25, 2020

Webrevs

Copy link
Collaborator

@fparain fparain left a comment

Looks good to me.
Do we need a test?

Fred

@hseigel
Copy link
Member Author

hseigel commented Jun 25, 2020

Hi Fred,
Do we need another test besides the test case that was added to test/jdk/java/lang/instrument/IsModifiableClassAgent.java ?
Thanks, Harold

@fparain
Copy link
Collaborator

fparain commented Jun 25, 2020

Sorry, I miss-read the second file. java.lang.IdentityObject is part of the well-known classes, so it is always loaded, so it covered by the test. Ignore my comment.

Thank you,

Fred

@hseigel
Copy link
Member Author

hseigel commented Jun 25, 2020

/integrate

@openjdk openjdk bot closed this Jun 25, 2020
@openjdk openjdk bot added integrated and removed ready labels Jun 25, 2020
@openjdk
Copy link

openjdk bot commented Jun 25, 2020

@hseigel
Pushed as commit 925f78d.

@openjdk openjdk bot removed the rfr label Jun 25, 2020
@hseigel
Copy link
Member Author

hseigel commented Jun 25, 2020

You can redefine / retransform java.lang.Object.

@forax
Copy link
Member

forax commented Jun 25, 2020

i'm trying to understand why you can not redefine IdentityObject but your can redefine Object ?

@hseigel
Copy link
Member Author

hseigel commented Jun 26, 2020

One reason is that interface java.lang.IdentityObject contains no functions so there's nothing to redefine.

@forax
Copy link
Member

forax commented Jun 26, 2020

But you don't need a special case for that ?

@hseigel
Copy link
Member Author

hseigel commented Jun 26, 2020

Our initial decision was that it did not make sense to allow java.lang.IdentityObject to be retransformed. Would you prefer that a JBS issue be entered to review this decision?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants